fix: handle Codex stdin errors - #156
Open
original4422 wants to merge 2 commits into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle errors from the spawned Codex stdin stream through the action's existing execution promise.
Fixes #153.
Root cause
runCodexExec()supervised child startup and exit events, but wrote the prompt throughchild.stdinwithout anerrorlistener. If Codex exited before consuming a buffered prompt, the resultingEPIPEbecame an uncaught EventEmitter error and crashed the helper.Changes
child.stdinbefore writing the prompt;Unhandled 'error' eventpath;dist/main.jsbundle.Validation
mainwith uncaughtError: write EPIPE.pnpm run check— passed.pnpm test— 145 tests: 142 passed, 3 platform-dependent tests skipped on macOS.git diff --check— passed.Risk
Low. Normal stdin delivery and child exit handling are unchanged. The new listener only routes a previously unhandled stream error into the promise that already owns execution failures.