fix: reject signal-terminated drop-sudo commands - #155
Open
original4422 wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat child processes terminated by a signal as failed
drop-sudocommands instead of normalizing their null exit code to zero.Fixes #152.
Root cause
Node reports
code === nulland supplies the terminating signal separately for a signal-terminated child. The sharedexecCommand()helper usedcode ?? 0, so required privilege-transition commands could resolve successfully after interruption.Changes
codeis null and include the signal in the diagnostic;close(null, "SIGTERM");dist/main.jsbundle.Validation
mainwithMissing expected rejection.node --test test/linuxCredentials.test.mjs— 5 passed.pnpm run check— passed.pnpm test— 145 tests: 142 passed, 3 platform-dependent tests skipped on macOS.git diff --check— passed.Risk
Low. Numeric exit handling is unchanged. Signal termination is now a failure for required commands and remains non-throwing only at call sites that explicitly set
ignoreFailure.