feat: add Accept header for integration tests - #714
Conversation
|
|
||
| createHeaders() { | ||
| return { | ||
| 'Accept': 'application/vnd.openactive.booking+json; version=1', |
There was a problem hiding this comment.
If I've understood content negotiation properly, this is needed for all requests to Bookings Systems
| createHeaders() { | ||
| return { | ||
| 'Accept': 'application/vnd.openactive.booking+json; version=1', | ||
| 'Content-Type': 'application/vnd.openactive.booking+json; version=1', |
There was a problem hiding this comment.
This is needed to say what the content type of the request is
lukehesluke
left a comment
lukehesluke
left a comment
There was a problem hiding this comment.
@civsiv it looks like the Broker has two places where it sets the wrong Accept headers also. It sets Accept: 'application/json, application/vnd.openactive.booking+json; version=1',, which has an extraneous application/json.
It is possible there's some legacy reason for this
|
Also, packages/openactive-integration-tests/test/global-setup.js's |
2 participants
No description provided.