Skip to content

feat: Add more metrics signal in fake data generator#2566

Merged
jmacd merged 6 commits intoopen-telemetry:mainfrom
ThomsonTan:add_metrics_perf_test
Apr 14, 2026
Merged

feat: Add more metrics signal in fake data generator#2566
jmacd merged 6 commits intoopen-telemetry:mainfrom
ThomsonTan:add_metrics_perf_test

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Change Summary

Updates the static metrics signal generator from a minimal 2-type (Sum/Gauge) alternation with fixed attributes to a realistic multi-type signal covering all five OTLP metric kinds, with configurable attributes and data points per metric.

What issue does this PR close?

  • Closes #NNN

How are these changes tested?

The changes are tested via 5 new unit tests

Are there any user-facing changes?

@ThomsonTan ThomsonTan requested a review from a team as a code owner April 7, 2026 03:04
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 99.00332% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.06%. Comparing base (9f8e589) to head (0337868).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2566    +/-   ##
========================================
  Coverage   88.06%   88.06%            
========================================
  Files         631      631            
  Lines      233175   233445   +270     
========================================
+ Hits       205349   205591   +242     
- Misses      27302    27330    +28     
  Partials      524      524            
Components Coverage Δ
otap-dataflow 89.77% <99.00%> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.74% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.27% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lalitb
Copy link
Copy Markdown
Member

lalitb commented Apr 7, 2026

This looks good for making the static metrics generator much more useful than the previous minimal implementation. One high-level suggestion as subsequent PR - consider making the metric generation more invariant-driven, where one underlying synthetic distribution is chosen first and the related fields are derived from it. That would reduce the chance of internal inconsistencies (as we see now) and make the generated metrics feel more realistic.

@jmacd jmacd added this pull request to the merge queue Apr 14, 2026
Merged via the queue into open-telemetry:main with commit c77dd27 Apr 14, 2026
70 of 71 checks passed
JakeDern pushed a commit to JakeDern/otel-arrow that referenced this pull request Apr 15, 2026
…2566)

# Change Summary

Updates the static metrics signal generator from a minimal 2-type
(Sum/Gauge) alternation with fixed attributes to a realistic multi-type
signal covering all five OTLP metric kinds, with configurable attributes
and data points per metric.

## What issue does this PR close?

<!--
We highly recommend correlation of every PR to an issue
-->

* Closes #NNN

## How are these changes tested?

The changes are tested via 5 new unit tests

## Are there any user-facing changes?

 <!-- If yes, provide further info below -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants