feat: Add more metrics signal in fake data generator#2566
Merged
jmacd merged 6 commits intoopen-telemetry:mainfrom Apr 14, 2026
Merged
feat: Add more metrics signal in fake data generator#2566jmacd merged 6 commits intoopen-telemetry:mainfrom
jmacd merged 6 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
========================================
Coverage 88.06% 88.06%
========================================
Files 631 631
Lines 233175 233445 +270
========================================
+ Hits 205349 205591 +242
- Misses 27302 27330 +28
Partials 524 524
🚀 New features to boost your workflow:
|
cijothomas
reviewed
Apr 7, 2026
lalitb
reviewed
Apr 7, 2026
lalitb
reviewed
Apr 7, 2026
Member
|
This looks good for making the static metrics generator much more useful than the previous minimal implementation. One high-level suggestion as subsequent PR - consider making the metric generation more invariant-driven, where one underlying synthetic distribution is chosen first and the related fields are derived from it. That would reduce the chance of internal inconsistencies (as we see now) and make the generated metrics feel more realistic. |
jmacd
reviewed
Apr 9, 2026
jmacd
approved these changes
Apr 14, 2026
Merged
via the queue into
open-telemetry:main
with commit Apr 14, 2026
c77dd27
70 of 71 checks passed
JakeDern
pushed a commit
to JakeDern/otel-arrow
that referenced
this pull request
Apr 15, 2026
…2566) # Change Summary Updates the static metrics signal generator from a minimal 2-type (Sum/Gauge) alternation with fixed attributes to a realistic multi-type signal covering all five OTLP metric kinds, with configurable attributes and data points per metric. ## What issue does this PR close? <!-- We highly recommend correlation of every PR to an issue --> * Closes #NNN ## How are these changes tested? The changes are tested via 5 new unit tests ## Are there any user-facing changes? <!-- If yes, provide further info below -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Updates the static metrics signal generator from a minimal 2-type (Sum/Gauge) alternation with fixed attributes to a realistic multi-type signal covering all five OTLP metric kinds, with configurable attributes and data points per metric.
What issue does this PR close?
How are these changes tested?
The changes are tested via 5 new unit tests
Are there any user-facing changes?