chore: docker image housekeeping - #2011
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
============================================
+ Coverage 68.04% 68.10% +0.06%
Complexity 3083 3083
============================================
Files 459 459
Lines 9031 9031
============================================
+ Hits 6145 6151 +6
+ Misses 2886 2880 -6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
thompson-tomo
changed the title
PuvaanRaaj
left a comment
PuvaanRaaj
left a comment
There was a problem hiding this comment.
Reviewed the Docker image housekeeping changes and validated the changed image references with docker manifest inspect. Two references in the current head do not resolve and would break the affected Compose workflows.
| services: | ||
| web: | ||
| image: nginx:alpine@sha256:54f2a904c251d5a34adf545a72d32515a15e08418dae0266e23be2e18c66fefa | ||
| image: nginx:1.30.4-alpine@sha256:sha256:59d10bca5c674965ef4ff884715000dd60ef5567c36663523f108eec8e4105d4 |
There was a problem hiding this comment.
This reference contains a duplicated sha256 prefix. I verified that docker manifest inspect fails for the current value. It should use a single digest prefix: nginx:1.30.4-alpine@sha256:59d10bca5c674965ef4ff884715000dd60ef5567c36663523f108eec8e4105d4.
| - collector | ||
| zipkin: | ||
| image: openzipkin/zipkin-slim@sha256:fc29b9862c14f4fc241cf0259c585e1cfd4e9b18f01ad36d86adaabb7d01815c | ||
| image: openzipkin/zipkin-slim3:6.1@sha256:fc29b9862c14f4fc241cf0259c585e1cfd4e9b18f01ad36d86adaabb7d01815c |
There was a problem hiding this comment.
This changes the repository name from openzipkin/zipkin-slim to openzipkin/zipkin-slim3 and the resulting reference does not resolve. I verified that docker manifest inspect fails here, while openzipkin/zipkin-slim:3.6.1@sha256:fc29b9862c14f4fc241cf0259c585e1cfd4e9b18f01ad36d86adaabb7d01815c resolves successfully.
|
@PuvaanRaaj Issues have been fixed |
PuvaanRaaj
left a comment
PuvaanRaaj
left a comment
There was a problem hiding this comment.
Follow-up review on the updated head: the nginx digest reference is corrected, but the revised Zipkin tag still has an invalid separator.
| - collector | ||
| zipkin: | ||
| image: openzipkin/zipkin-slim@sha256:fc29b9862c14f4fc241cf0259c585e1cfd4e9b18f01ad36d86adaabb7d01815c | ||
| image: openzipkin/zipkin-slim:3:6.1@sha256:fc29b9862c14f4fc241cf0259c585e1cfd4e9b18f01ad36d86adaabb7d01815c |
There was a problem hiding this comment.
Thanks for the quick update. This value is still not a valid Docker reference because it contains two tag separators (:3:6.1). The resolving form is openzipkin/zipkin-slim:3.6.1@sha256:fc29b9862c14f4fc241cf0259c585e1cfd4e9b18f01ad36d86adaabb7d01815c.
|
Apologies didn't notice that the : had gone after the 3. Has been fixed. |
2 participants
Explicitly pin docker version to improve info/context available to renovate.
The jaegar tracing image has been switched as existing image is eol jaegertracing/jaeger#6321