fix(ibm-mq-metrics): update metric unit from 'microseconds' to 'us'#2887
fix(ibm-mq-metrics): update metric unit from 'microseconds' to 'us'#2887harshitt13 wants to merge 2 commits into
Conversation
Signed-off-by: Harshit Kushwaha <find.harshitkushwaha@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2642857fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…r consistency Signed-off-by: Harshit Kushwaha <find.harshitkushwaha@gmail.com>
| brief: "Queue message oldest age" | ||
| instrument: gauge | ||
| unit: "microseconds" | ||
| unit: "s" |
There was a problem hiding this comment.
Why do this one as seconds when the rest are microseconds?
There was a problem hiding this comment.
chatgpt-codex-bot caught that the underlying IBM MQ parameter for oldest.msg.age (MQIACF_OLDEST_MSG_AGE) actually returns its value in seconds, not microseconds, according to the IBM MQ queue-status response documentation.
If we changed oldest.msg.age to us, downstream unit-aware backends would interpret the data completely wrong, a 10-second-old message would be parsed as 10 microseconds old.
Description:
This PR updates the metric unit for time-based metrics (
oldest.msg.age,onqtime.short_period,onqtime.long_period) from"microseconds"to"us".Existing Issue(s):
Fixes #2838
Documentation:
Updated
docs/metrics.mdto reflect the correctusunit in the markdown tables.