fix: preserve expiry ownership and queued failure evidence - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expired Verify could admit recovery before its reporting finished and omit the original issued Change from results and records. Both expiry paths now reserve publication ownership under the decision lock, preserve command evidence, and share finalization without releasing an enclosing Issue call.
Queued Runs now retain observer failures, original causes, and stacks from committed Steps when a later callback calls runtime.Goexit. The queued fuzz model checks exact event order, effect counts, independent cursors, and explicit cancellation outcomes. Full local/CI checks also scan the SQLite module's test dependencies for known vulnerabilities.
This addresses all four numbered review findings with compatible behavior fixes. Package documentation, the ADR, safety guidance, assurance requirements, and changelog describe the corrected guarantees. The review and before/after evidence are retained in scratch/review-2026-09-10.
Validation:
Statechart scaling and broader integration examples remain separate recommendations. No public method signatures or snapshot schema change.