Skip to content

feat(ui): Data Quality dashboard data product filter#27129

Merged
ShaileshParmar11 merged 6 commits intomainfrom
issue-27124
Apr 9, 2026
Merged

feat(ui): Data Quality dashboard data product filter#27129
ShaileshParmar11 merged 6 commits intomainfrom
issue-27124

Conversation

@shah-harshit
Copy link
Copy Markdown
Contributor

@shah-harshit shah-harshit commented Apr 7, 2026

Summary

  • Data Quality dashboard: Adds a Data products filter to the dashboard filter bar, wires it through list/aggregation APIs and Elasticsearch filters, and extends types/constants/tests accordingly.
  • Incident manager (inline test case status): Refactors InlineTestCaseIncidentStatus to use @openmetadata/ui-core-components for layout and actions, uses a MUI Chip (filled, medium) for the status control so it matches the design system and anchors dropdowns/popovers correctly, and updates unit tests/mocks.

Test plan

  • yarn test InlineTestCaseIncidentStatus.test.tsx
  • yarn lint (or relevant UI lint) for touched files
  • Manual: DQ dashboard — filter by data product; open inline status on a test case row — menu/popover placement and chip appearance

Fixes #27124

@shah-harshit shah-harshit requested a review from a team as a code owner April 7, 2026 11:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.27% (59592/92715) 43.78% (31068/70963) 46.94% (9371/19960)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🟡 Playwright Results — all passed (21 flaky)

✅ 3597 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 207 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 455 0 2 2
🟡 Shard 2 641 0 1 32
🟡 Shard 3 647 0 4 26
🟡 Shard 4 617 0 5 47
🟡 Shard 5 606 0 1 67
🟡 Shard 6 631 0 8 33
🟡 21 flaky test(s) (passed on retry)
  • Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/LandingPageWidgets/DomainDataProductsWidgets.spec.ts › Assign Widgets (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/SettingsNavigationPage.spec.ts › should save changes and navigate when "Save changes" is clicked in blocker (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for ApiEndpoint (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Add and update Security and SLA tabs (shard 4, 1 retry)
  • Pages/DomainAdvanced.spec.ts › Filter assets by domain from explore page (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with assets (tables, topics, dashboards) preserves associations (shard 4, 1 retry)
  • Pages/ExploreTree.spec.ts › Verify Database and Database Schema available in explore tree (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Create term with related terms, tags and owners during creation (shard 6, 1 retry)
  • Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
  • Pages/InputOutputPorts.spec.ts › Input ports list displays entity cards (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/ProfilerConfigurationPage.spec.ts › Non admin user (shard 6, 1 retry)
  • Pages/Users.spec.ts › Create and Delete user (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@shah-harshit shah-harshit changed the title fix: Data Quality dashboard data product filter feat(ui): Data Quality dashboard data product filter Apr 7, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 9, 2026

Code Review ✅ Approved 2 resolved / 2 findings

Adds data product filter and incident status chip to the Data Quality dashboard UI. Resolved Playwright test cleanup issues and domain object lifecycle ordering, with no remaining concerns.

✅ 2 resolved
Bug: Playwright test cleanup (afterAll) entirely removed

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/DataQualityDashboard.spec.ts:158
The diff removes the entire test.afterAll('cleanup', ...) block that was responsible for deleting all test fixtures (table1, table2, table3, user1, glossaryTerm, glossary, tag, tier, classification). The new domain and dataProduct entities are also created in beforeAll but never cleaned up. This means every test run will leak entities into the test environment, which can cause flaky tests and accumulating test data.

This looks like an accidental deletion — the cleanup for the new entities should have been added to the existing afterAll block, not the entire block removed.

Bug: dataProduct deleted after its parent domain — cleanup may fail

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/DataQualityDashboard.spec.ts:173-174
On line 173-174, domain.delete() is called before dataProduct.delete(). Since dataProduct is a child of domain (created as new DataProduct([domain]) on line 54), deleting the domain first will either cascade-delete the data product (making the subsequent delete call fail with a 404) or fail itself due to a foreign-key/child constraint.

The cleanup order should mirror the reverse of creation order: delete children before parents.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

@ShaileshParmar11 ShaileshParmar11 merged commit 8d23a35 into main Apr 9, 2026
52 of 53 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the issue-27124 branch April 9, 2026 13:08
@shah-harshit shah-harshit changed the title feat(ui): Data Quality dashboard data product filter and incident status chip feat(ui): Data Quality dashboard data product filter Apr 10, 2026
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
…tus chip (open-metadata#27129)

* fix: add data product filter to Data Quality dashboard

Fixes open-metadata#27124

Made-with: Cursor

* address comments

* minor fix

* fix lint

* address gitar-bot comments
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
…tus chip (open-metadata#27129)

* fix: add data product filter to Data Quality dashboard

Fixes open-metadata#27124

Made-with: Cursor

* address comments

* minor fix

* fix lint

* address gitar-bot comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Data product filter in Data Quality Dashboard

2 participants