Repository navigation
docs: claim spec v0.9.0 - #362
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jose Colella <jose.colella@gusto.com>
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 59 minutes. View limit details
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 34 34
Lines 966 966
=======================================
Hits 964 964
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔵 Needs a closer look
A maintainer must verify that prerequisite PRs #360 and #361 have merged before approving the compliance claim.
No open issues 🎉
What changed in this PR
Updates the Ruby SDK’s documented specification version to v0.9.0 as the final step in the compliance work tracked by #300. The claim depends on #360 and #361 merging first.
Changes:
- Updates the specification badge from v0.8.0 to v0.9.0.
- Points the badge link to the corresponding specification release; no runtime code changes.
| File | Description |
|---|---|
| README.md | Updates the specification badge version and release link. |
Review effort: Balanced
The release PR was generated from README.md before #362 landed and reverted the badge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jose Colella <jose.colella@gusto.com>
Closes #300. Merge after #360 and #361: the claim depends on both. 0.8.0 shipped before them, so the first release that meets the claim is the one after #361 (0.8.1).
Moves the README's specification badge from v0.8.0 to v0.9.0, the version the spec submodule is pinned to (d5b0a73).
Compliance summary
A compliance audit checked every requirement in sections 1–6 and Appendix A on
main(9e166fe), reading each test's body rather than its label. Once #361 (behavior fixes) and #360 (missing tests) merge, every MUST and MUST NOT is met or n/a. The one exception is 1.4.10, which we read with the two calls listed below.For every other MUST, the audit found the implementing code and a test that exercises it.
n/a, by condition:
finallyisn't a reserved word in Ruby.How we read 1.4.10 (MUST NOT throw):
ArgumentError. We treat it as Ruby's equivalent of a compile-time type error.StandardErrorandNotImplementedErrorpropagate. These includeInterrupt,SignalException,SystemExit,NoMemoryError,SystemStackErrorandScriptErrorsubclasses such asLoadError. Rescuing them would hide process-level failures and signals.Other calls worth knowing:
set_provider_and_waitcan return READY from inside a handler (1.1.2.4). Each event's status is still recorded before its own handlers run.EventEmitter.Deferred from #300:
ProviderMetadata, which saves a copy on every hooked evaluation: a contrib follow-up.🤖 Generated with Claude Code