Repository navigation
test(flagd): run the remaining flagd-testbed scenarios as TCK extensions #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aepfli
wants to merge
27
commits into
main
Choose a base branch
from
feat/provider-tck-flagd-extensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+343
−963
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a04784d
test(flagd): add a seam for flagd-specific TCK extension scenarios
aepfli f5ca143
test(flagd): restore the default launchpad configuration after an ext…
aepfli 9dd94b3
test(flagd): select the fractional bucketing version by tag
aepfli 4dfa21a
test(flagd): port the testbed's evaluation, disabled and selector sce…
aepfli 151d011
test(flagd): port the testbed's non-fractional targeting scenarios as…
aepfli a467ab7
test(flagd): port the testbed's metadata, sync-payload and context en…
aepfli 1385925
test(flagd): port the testbed's connection, event and caching scenari…
aepfli 526de6b
test(flagd): port the testbed's fractional scenarios as a TCK extension
aepfli 4efde90
test(flagd): port the testbed's fractional v2 scenarios
aepfli 4ad2140
style(flagd): apply spotless to the fractional version gate
aepfli 57e45ab
test(flagd): require a resolver tag on every extension scenario
aepfli 89b573c
test(flagd): select extension scenarios with the TCK's tag annotations
aepfli 1bc8266
test(flagd): drop the resolver-tag check
aepfli fe6f0a2
test(flagd): run the TCK against the flagd-testbed's own compose file
aepfli d6d9c87
test(flagd): drop the TCK profile's submodule checkout
aepfli 3780a01
test(flagd): drop the TCK profile
aepfli a130054
test(flagd): use the TCK's steps instead of flagd-shaped copies
aepfli 5067e6f
test(flagd): assert the outage by its events, not by its length
aepfli 0ba02f2
test(flagd): hand the event-order assertion back to the TCK
aepfli f515bdb
test(flagd): hand the flag-metadata assertions back to the TCK
aepfli 1394e21
style(flagd): drop two blank lines the step removals left behind
aepfli a41c007
docs(flagd): the metadata extension does keep @file
aepfli 3d16473
test(flagd): port the fractional composition scenarios new in testbed…
aepfli 7f33c93
test(flagd): replace the legacy e2e suites with the TCK extensions
aepfli 453ec78
test(flagd): read the TCK extensions from flagd-testbed
aepfli 45a85c8
test(flagd): follow flagd-testbed#445's portable feature files
aepfli 58ee7ad
test(flagd): follow flagd-testbed#445 to c5ac5de
aepfli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...iders/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/config/ConfigState.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package dev.openfeature.contrib.providers.flagd.config; | ||
|
|
||
| import dev.openfeature.contrib.providers.flagd.FlagdOptions; | ||
|
|
||
| /** Scenario state shared by the config steps, one instance per scenario. */ | ||
| public class ConfigState { | ||
| public FlagdOptions options; | ||
| public FlagdOptions.FlagdOptionsBuilder builder = FlagdOptions.builder(); | ||
| public boolean hasError; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...d/e2e/steps/EnvironmentVariableUtils.java → ...lagd/config/EnvironmentVariableUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...trib/providers/flagd/e2e/steps/Utils.java → ...contrib/providers/flagd/config/Utils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 0 additions & 50 deletions
50
...iders/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerEntry.java
This file was deleted.
Oops, something went wrong.
116 changes: 0 additions & 116 deletions
116
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerPool.java
This file was deleted.
Oops, something went wrong.
32 changes: 0 additions & 32 deletions
32
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerUtil.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initialize
test-harnessfor the TCK profile.On a fresh checkout, the documented
mvn -Ptck -pl providers/flagd -am testcommand does not activate thee2eprofile. That profile alone initializestest-harness. Maven therefore cannot copy these extension features, and the resolver suites cannot find their Compose file. Make submodule initialization part of the TCK workflow, or require it explicitly before the documented command. (raw.githubusercontent.com)