feat(hooks): add codereadiness hook by NeaguGeorgiana23 · Pull Request #148 · open-feature/cpp-sdk-contrib

NeaguGeorgiana23 · 2026-11-02T15:21:25Z

This PR

adds the codereadiness hook: an OpenFeature after hook that fails
a flag evaluation when the running binary's version is lower than the
minimum version stored in the flag's metadata (default key
minCodeVersion). On failure the hook throws, so the SDK resolves the
flag to its default value.
adds CodeReadinessHookOptions:
- strict_validation: when true, missing or malformed version data
  fails the evaluation; when false (the default) it is logged at
  VLOG(1) and the check is skipped. A well-formed current version
  lower than the required one always fails the evaluation.
- min_version_metadata_key: the metadata key to read the required
  version from.
- comparator: an optional custom VersionComparator.
adds the VersionComparator interface as an extension point for
non-SemVer version schemes.
adds SemVer and SemVerComparator, the default implementation:
SemVer 2.0.0 precedence with golang.org/x/mod/semver-style parsing
(optional v prefix, MAJOR and MAJOR.MINOR shorthands). Build
metadata is validated but ignored.
- uses one format for every error message:
  codereadiness: flag "<key>": <detail>.
adds unit tests for SemVer parsing and precedence, for
SemVerComparator (including concurrent Compare() calls), and for
the hook in strict and lenient modes.
adds a README with setup, configuration and custom-comparator examples.

Related Issues

Fixes #147

Follow-up Tasks

A very similar version of the SemVer lass is already implemented in providers/flagd/src/evaluator/flagd_ops.cpp. Move this to a common folder such that the code can be reused.

How to test

bazel test //hooks/codereadiness/...

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

coderabbitai · 2026-11-02T15:21:33Z

Important

Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: e28fdfba-bb2c-4840-bc3c-e2d2be5a3f05

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

Run CodeRabbit Verify to test the changes in this pull request.

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Copilot

🟡 Changes recommended

The global -mno-bmi2 flag breaks non-x86 builds, while CI omits the new hook tests and lenient mode still invokes comparison after comparator initialization fails.

3 open issues

Global -mno-bmi2 breaks non-x86 builds · New
Lenient mode compares versions after initialization fails · New
CI does not run the new hook tests · New

What changed in this PR

Adds a configurable OpenFeature code-readiness hook for #147, allowing flag evaluations to fall back to their default value when the application version is below the flag’s required minimum.

Changes:

Adds the hook with strict and lenient validation, a configurable metadata key, and custom comparator support.
Implements SemVer parsing and comparison, with unit tests and usage documentation.
Adds Bazel library/test targets and compiler workarounds.

File	Description
`hooks/codereadiness/tests/semver_test.cpp`	Tests parsing and version precedence.
`hooks/codereadiness/tests/semver_comparator_test.cpp`	Tests comparator initialization, results, and concurrent calls.
`hooks/codereadiness/tests/codereadiness_test.cpp`	Tests validation modes, metadata, and custom comparators.
`hooks/codereadiness/tests/BUILD`	Defines three test targets.
`hooks/codereadiness/src/version_comparator.h`	Defines the custom comparator interface.
`hooks/codereadiness/src/semver.h`	Declares the semantic-version model.
`hooks/codereadiness/src/semver.cpp`	Implements parsing and precedence rules.
`hooks/codereadiness/src/semver_comparator.h`	Declares the default comparator.
`hooks/codereadiness/src/semver_comparator.cpp`	Implements minimum-version comparisons.
`hooks/codereadiness/src/codereadiness.h`	Defines hook options and public API.
`hooks/codereadiness/src/codereadiness.cpp`	Implements metadata validation and evaluation failures.
`hooks/codereadiness/src/BUILD`	Defines public library targets.
`hooks/codereadiness/README.md`	Documents setup, behavior, and customization.
`hooks/codereadiness/LICENSE`	Adds the Apache 2.0 license.
`.bazelrc`	Adds BoringSSL warning and BMI2 compiler workarounds.

_{Review effort: Balanced}

NeaguGeorgiana23 · 2026-11-03T09:30:05Z

+build --copt=-mno-bmi2
+build --host_copt=-mno-bmi2


@m-olko wdyt about this comment? I added the workaround because build was failing without it.

Have you tried updating bazel to 20260817.0? I have seen some threads about similar issues and theoretically they have been fixed with newer versions

Other question is why abseil is not updated automatically by renovate

+    VLOG(1) << "codereadiness: invalid current version \"" << current_version
+            << "\": " << status;
+  }


+load("@rules_cc//cc:defs.bzl", "cc_test")
+
+cc_test(
+    name = "semver_test",


Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

m-olko · 2026-11-03T11:31:49Z

The current version of cpp-sdk doesn't have HookLifecycle implemented, from what I have seen, that's why you need to create manual RunAfter function in your tests. Could you first create new release on cpp-sdk with Hooks fully implemented, and then test the hook in e2e fashion, using openfeature provider?

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

oxddr · 2026-11-03T11:31:42Z

+  if (absl::Status status = comparator->Initialize(current_version);
+      !status.ok()) {
+    if (options.strict_validation) {
+      return absl::Status(
+          status.code(),
+          absl::StrCat("codereadiness: comparator initialization failed: ",
+                       status.message()));
+    }
+    VLOG(1) << "codereadiness: invalid current version \"" << current_version
+            << "\": " << status;
+  }


Inability to initialize the comparator should fail Create() in all modes, not only when strict_validation is enabled. An invalid current_version at startup means the hook is misconfigured, so we should surface that error to the caller immediately rather than creating a broken hook that never validates anything.

Failing Create() unconditionally when comparator->Initialize(current_version) returns a non-OK status also means Compare() is only ever called on a successfully initialized comparator, which simplifies SemVerComparator (no need to track current_version_ or std::optional<SemVer> for uninitialized state) and custom VersionComparator implementations.

oxddr · 2026-11-03T11:31:42Z

+                            current_version_, "\" - minimum: \"",
+                            *min_code_version, "\" for flag \"", flag_key,
+                            "\": ", meets_min_version.status().message()));
+    return;
+  }
+  if (!*meets_min_version) {
+    throw std::runtime_error(
+        absl::StrCat("current version: \"", current_version_,
+                     "\" required minimum version: \"", *min_code_version,
+                     "\" flag \"", flag_key, "\", check failed"));
+  }
+}
+
+void CodeReadinessHook::FailOrSkip(const std::string& message) const {
+  if (strict_validation_) {
+    throw std::runtime_error(message);
+  }
+  VLOG(1) << "codereadiness: " << message << ", skipping validation";
+}


The PR description notes that error messages follow the format codereadiness: flag "<key>": <detail>, and Create() prefixes statuses with codereadiness: , but After() and FailOrSkip() only include the codereadiness: prefix in the VLOG(1) output and omit it from the thrown std::runtime_error messages.

Could we align the thrown exception messages with the documented format (or update the PR description if the Go hook's message format is intentional here)?

oxddr · 2026-11-03T11:31:42Z

+load("@rules_cc//cc:defs.bzl", "cc_test")
+
+cc_test(
+    name = "semver_test",


+1 to updating .github/workflows/ci-format-test-lint.yml so the test step runs bazel test //... (or includes //hooks/...), and updating HeaderFilterRegex in .clang-tidy from ".*/flagd/.*" to ".*/(flagd|hooks)/.*" so headers under hooks/ are also checked by clang-tidy.

m-olko · 2026-11-03T13:43:16Z

+namespace codereadiness {
+
+// Represents a Semantic Version (SemVer 2.0.0) for comparison.
+// Parsing follows golang.org/x/mod/semver: optional leading 'v'/'V', MAJOR and


NIT: I think other languages accept only 'v' prefix: https://github.com/open-feature/go-sdk-contrib/blob/main/hooks/codereadiness/codereadiness.go#L17

feat(hooks): add codereadiness hook

8f46b52

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Fix build error.

b6340ef

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 force-pushed the codereadiness_hook branch from cd2ef9d to b6340ef Compare November 2, 2026 16:24

NeaguGeorgiana23 requested review from m-olko and a balanced review from Copilot November 3, 2026 09:19

Copilot started reviewing on behalf of NeaguGeorgiana23 November 3, 2026 09:19

View session

NeaguGeorgiana23 requested a review from oxddr November 3, 2026 09:21

Copilot AI reviewed Nov 3, 2026

View reviewed changes

fix clang

751290a

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 force-pushed the codereadiness_hook branch from bb3eab4 to 751290a Compare November 3, 2026 10:04

Updating abseil to 20260817.0

2a3fbb9

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

oxddr reviewed Nov 3, 2026

View reviewed changes

m-olko approved these changes Nov 3, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(hooks): add codereadiness hook - #148

feat(hooks): add codereadiness hook#148
NeaguGeorgiana23 wants to merge 4 commits into
mainfrom
codereadiness_hook

NeaguGeorgiana23 commented Nov 2, 2026

Uh oh!

coderabbitai Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

NeaguGeorgiana23 Nov 3, 2026

Uh oh!

m-olko Nov 3, 2026 •

edited

Loading

Uh oh!

m-olko commented Nov 3, 2026

Uh oh!

Uh oh!

oxddr Nov 3, 2026

Uh oh!

oxddr Nov 3, 2026

Uh oh!

oxddr Nov 3, 2026

Uh oh!

m-olko Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

NeaguGeorgiana23 commented Nov 2, 2026

This PR

Related Issues

Follow-up Tasks

How to test

Uh oh!

coderabbitai Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeRabbit Verify

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

NeaguGeorgiana23 Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

m-olko Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m-olko commented Nov 3, 2026

Uh oh!

Uh oh!

oxddr Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

oxddr Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

oxddr Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

m-olko Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Nov 2, 2026 •

edited

Loading

m-olko Nov 3, 2026 •

edited

Loading