Bugfix: Handle non-numeric oid query parameter in GetClassDefinitionForColumnConfigPayload - #115
Merged
Merged
Conversation
…onForColumnConfigPayload`
solverat
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
=> Adopted according to https://github.com/open-dxp/admin-bundle/blob/1.x/src/Handler/DataObject/Classificationstore/GetGroups/GetGroupsPayload.php#L53
Additional Info
Imo it is not necessary to use
nullhere as fallback since the parameter is used to determine DataObjects which have aID >= 1. All methods/helpers called with this param simply return if the value is< 1. So setting it to0(int) should be sufficient.