Skip to content

Add the incident overlay renderer and the settings-secrets picture (INC-2) - #407

Merged
jothimani-rajendran merged 2 commits into
mainfrom
inc2-claude-settings-secrets
Nov 21, 2026
Merged

jothimani-rajendran merged 2 commits into
mainfrom
inc2-claude-settings-secrets

Conversation

@jothimani-rajendran

@jothimani-rajendran jothimani-rajendran commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

What

A reusable overlay renderer that draws one incident on the published harness figure (where-chock-sits.json and .mjs, unchanged), and its first picture, docs/assets/readme/v2/incidents/claude-settings-secrets.png, titled "Keep the agent's local settings out of git".

  • Red path along the existing cards and arrows; cards off the path are dimmed.
  • Solid ring: the commit badge, where a real git commit of two fake settings files was refused by scan-secrets (exit 1). A clean settings file committed (exit 0). Run by the owner, recorded in the org-plan witness PR.
  • Dashed rings: three places a rule could be added (prompt submit, pre-tool, file changed). They claim no catch.
  • The refusal text is printed under the map, trimmed with "...". The product name appears only in the footer.
  • Per-incident data is a small JSON: docs/assets/readme/incidents/<slug>.json. Render with node docs/assets/readme/render-incident.mjs <slug>.

Source of the incident: Apiiro, 2026-11-05, and GitGuardian, 2026-11-09 (cited in the witness record).

Definition of done

  • ruff check . and ruff format --check . clean
  • tests/test_incident_overlay.py, tests/test_repo_standards.py (line budget) and tests/test_readme_* pass locally
  • changelog.d/inc2-incident-overlay.md fragment
  • Full suite: left to CI

Claims

  • Does not touch the README, the existing figures, .chock/ or any owner-only file.
  • The only recorded verdict is the commit gate. Nothing is claimed for CI, the agent's pre-tool hook, or the PGPASSWORD=value form.

Draws an incident path on the published harness figure: red path, dimmed
cards off it, ringed catch points (solid where a proof recorded a refusal,
dashed where a rule can be added) and the refusal text under the map.

Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
@jothimani-rajendran
jothimani-rajendran marked this pull request as ready for review November 20, 2026 02:32
@jothimani-rajendran
jothimani-rajendran merged commit f429a76 into main Nov 21, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant