Repository navigation
Render the harness figure in the site palette (RD-8) - #404
Merged
Merged
Conversation
The figure renderer takes a palette object instead of constants. The default palette is today's, so the committed where-chock-sits.png renders to the same pixels. A second render key, v2/where-chock-sits-site, uses the chock-site tokens. Tests check both PNGs exist at the same size and that the two renders differ only in colour. Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
Collaborator
Author
|
The
Nothing else is waiting on me here. Generated by Claude Code |
Collaborator
Author
|
Generated by Claude Code |
jothimani-rajendran
marked this pull request as ready for review
November 18, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RD-8 from the 1.2.0 plan. The figure renderer takes a palette object instead of constants. The default palette is today's, and re-rendering
v2/where-chock-sits.pnggives identical pixels (same 1760x2008 size, no differing pixel; the PNG bytes differ only in encoding, so the committed file is not touched). A second render key,v2/where-chock-sits-site, uses the chock-site palette and producesdocs/assets/readme/v2/where-chock-sits-site.png.New tests check that both PNGs exist at the same size and that the two renders have the same layout and differ only in colour. The existing figure tests are unchanged.
Definition of done
chock check→ 0 errors, 0 warnings, 0 infos (not run: no engine change)chock check --only matrixpasses (not run: no engine change)chock sync --repo . --checkclean (not run:.chock/untouched)chock check --only verifyclean (not run:.chock/untouched)pytest tests/test_readme_picture.py tests/test_readme_derived.py tests/test_readme_wordcount.py→ 19 passedpytest acceptance/(not applicable: no packaging change)ruff check .andruff format --checkclean on the changed file (ruff 0.17.2)Claims
Generated by Claude Code