Skip to content

Render the harness figure in the site palette (RD-8) - #404

Merged
jothimani-rajendran merged 1 commit into
mainfrom
rd8-site-palette
Nov 18, 2026
Merged

jothimani-rajendran merged 1 commit into
mainfrom
rd8-site-palette

Conversation

@jothimani-rajendran

Copy link
Copy Markdown
Collaborator

What

RD-8 from the 1.2.0 plan. The figure renderer takes a palette object instead of constants. The default palette is today's, and re-rendering v2/where-chock-sits.png gives identical pixels (same 1760x2008 size, no differing pixel; the PNG bytes differ only in encoding, so the committed file is not touched). A second render key, v2/where-chock-sits-site, uses the chock-site palette and produces docs/assets/readme/v2/where-chock-sits-site.png.

New tests check that both PNGs exist at the same size and that the two renders have the same layout and differ only in colour. The existing figure tests are unchanged.

Definition of done

  • chock check → 0 errors, 0 warnings, 0 infos (not run: no engine change)
  • chock check --only matrix passes (not run: no engine change)
  • chock sync --repo . --check clean (not run: .chock/ untouched)
  • chock check --only verify clean (not run: .chock/ untouched)
  • Registry rescanned; no stale entries (not applicable)
  • README and picture tests green: pytest tests/test_readme_picture.py tests/test_readme_derived.py tests/test_readme_wordcount.py → 19 passed
  • pytest acceptance/ (not applicable: no packaging change)
  • Existing artifacts migrated (not applicable)
  • Touched manifests (not applicable)
  • ruff check . and ruff format --check clean on the changed file (ruff 0.17.2)

Claims

  • No enforcement claim changes; this is a rendering change only.

Generated by Claude Code

The figure renderer takes a palette object instead of constants. The default
palette is today's, so the committed where-chock-sits.png renders to the same
pixels. A second render key, v2/where-chock-sits-site, uses the chock-site
tokens. Tests check both PNGs exist at the same size and that the two renders
differ only in colour.

Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>

Copy link
Copy Markdown
Collaborator Author

The quickstart check fails here, and it is not caused by this PR.

  • The job installs chock==1.2.0 from PyPI, then chock add scan-secrets exits 2 with: catalog https://github.com/open-coder-ai/chock-catalog has no tag v1.2.0 for this chock.
  • The same workflow is already red on main at 5088f2f (the 1.2.0 merge, run 44311717084). This PR changes only docs/assets/readme/*.mjs, tests/test_readme_picture.py and one new PNG, none of which the quickstart reads.
  • The check should go green once chock-catalog has a v1.2.0 tag. That is a release step for the owner, so I have not touched it and have pushed nothing.

Nothing else is waiting on me here.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

quickstart is red for a reason outside this PR: chock add reports that the catalog has no tag v1.2.0 yet (has no tag v1.2.0 for this chock ... (nothing installed), exit code 2). That tag comes from the 1.2.0 release run. This PR only changes the diagram renderer and adds a PNG. quickstart is not a required check, and it goes green once the release tags the catalog.


Generated by Claude Code

@jothimani-rajendran
jothimani-rajendran marked this pull request as ready for review November 18, 2026 16:03
@jothimani-rajendran
jothimani-rajendran merged commit b4fa4f7 into main Nov 18, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant