Skip to content

Remove bamboo reliability exception - #9

Merged
HashimTheArab merged 1 commit into
oomph-ac:mainfrom
JavierLeon9966:agent/remove-bamboo-reliability-exception
Jul 23, 2026
Merged

Remove bamboo reliability exception#9
HashimTheArab merged 1 commit into
oomph-ac:mainfrom
JavierLeon9966:agent/remove-bamboo-reliability-exception

Conversation

@JavierLeon9966

@JavierLeon9966 JavierLeon9966 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Removed the bamboo-specific reliability exception from movement simulation.
  • Updated gophertunnel and refreshed module checksums.

Why

Bamboo no longer needs to force simulation results into the unreliable path, allowing normal reliability evaluation to continue for movement near bamboo.

Impact

Callers can receive normal simulation outcomes near bamboo when the remaining reliability conditions are satisfied.

Validation

  • gopls diagnostics: no diagnostics
  • go test .

Summary by CodeRabbit

  • Bug Fixes
    • Improved simulation reliability assessment by preventing nearby bamboo blocks from incorrectly lowering reliability.
    • Updated the underlying tunnel library to improve compatibility and stability.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d7e869f-aee2-4fee-a507-5a0ef2be4b7d

📥 Commits

Reviewing files that changed from the base of the PR and between 41ae0d7 and 2424174.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod
  • simulation.go

📝 Walkthrough

Walkthrough

The change updates the gophertunnel dependency and modifies simulation reliability by removing the nearby bamboo scan while retaining teleport, game mode, movement, and aliveness checks.

Changes

Dependency update

Layer / File(s) Summary
Gophertunnel revision update
go.mod
Updates github.com/sandertv/gophertunnel from v1.57.0 to a newer pseudo-version.

Simulation reliability

Layer / File(s) Summary
Simulation reliability criteria
simulation.go
Reorders imports and removes bamboo-based reliability downgrading from Simulator.simulationIsReliable; remaining teleport, game mode, movement, and aliveness checks are retained.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: hashimthearab

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing the bamboo-specific reliability exception.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@JavierLeon9966
JavierLeon9966 marked this pull request as ready for review July 21, 2026 19:46
@HashimTheArab
HashimTheArab merged commit 8987ee5 into oomph-ac:main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants