feat: ✨ describe relationship between weeks, visits, and instruments - #224
Open
K-Beicher wants to merge 11 commits into
Open
feat: ✨ describe relationship between weeks, visits, and instruments#224K-Beicher wants to merge 11 commits into
K-Beicher wants to merge 11 commits into
Conversation
lwjohnst86
requested changes
Aug 5, 2026
lwjohnst86
left a comment
lwjohnst86
left a comment
Member
There was a problem hiding this comment.
Here's some initial comments :)
Comment on lines
+3
to
+4
| W-4,1,"besg_1_screening, | ||
| bedq (1. time)", |
Member
There was a problem hiding this comment.
Keep this tidy (3NF), each cell should have only one instrument. This will mean duplicate weeks and visits, but that's part of the data being tidy.
For example:
Suggested change
| W-4,1,"besg_1_screening, | |
| bedq (1. time)", | |
| W-4,1,besg_1_screening, | |
| W-4,1,bedq (1. time), |
Repeat this for all the other rows too.
| @@ -0,0 +1,88 @@ | |||
| Weeks,Visit,Instrument name,Comments | |||
| W-5,0,prscreening_telefoninterview_frste_kontakt, | |||
Member
There was a problem hiding this comment.
We should stick with clear data types. Weeks should be an integer:
Suggested change
| W-5,0,prscreening_telefoninterview_frste_kontakt, | |
| -5,0,prscreening_telefoninterview_frste_kontakt, |
Repeat for the others too.
github-project-automation
Bot
moved this from In Review
to In Progress
in Data development
martonvago
reviewed
Aug 6, 2026
Comment on lines
+67
to
+88
| No week,,stamdata,"Running updates throughout weeks 1-52 | ||
| This form will contain basic information about the participant as well as information about drop-out or completion of study" | ||
| No week,,adverse_events,"Anytime throughout weeks 1-52 | ||
| This form will register any adverse event the participant experience throughout the study, the form has a date of completion and the dates of the event" | ||
| No week,,fase_1_ditetiske_afvigelser,"Anytime through weeks 1-11 | ||
| This form will register any deviation from the NUPO diet, the form has a date of completion and the dates of the event" | ||
| No week,,fase_2_ditetiske_afvigelser,"Anytime through weeks 12-18 | ||
| This form will register any deviation from the reintroduction of normal meals, the form has a date of completion and the dates of the event" | ||
| No week,,fase_3_ditetiske_afvigelser,"Anytime after week 18 | ||
| This form will register any deviation from the recommended diet, the form has a date of completion and the dates of the event" | ||
| No week,,trningsafvigelser,"Anytime after week 18 | ||
| This form will register any deviation from the recommended exercise, the form has a date of completion and the dates of the event" | ||
| No week,,ekstra_kontakt,"Anytime throughout weeks 1-52 | ||
| This form will capture any contact between study staff and the participant that falls outside the standard touch points. The form as a date for the contact and it is expected that the form is completed on the day of the contact." | ||
| No week,,hba1c_follow_up,"Anytime throughout weeks 1-52 | ||
| This form will register any extra HbA1c testing done at the lab if the study team suspects that there is a problem, the form as a date for the testing" | ||
| No week,,medicine_changes,"Anytime throughout weeks 1-52 | ||
| This form will register any changes to medicine during the study, the form has a date for the capture of the information" | ||
| No week,,individual_ditistsamtale_1,At some point between weeks 18 and 50 | ||
| No week,,individual_ditistsamtale_2,At some point between weeks 18 and 50 | ||
| No week,,individual_ditistsamtale_3,At some point between weeks 18 and 50 | ||
| No week,,individual_ditistsamtale_4,At some point between weeks 18 and 50 |
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
lwjohnst86
changed the title
lwjohnst86
changed the title
is this a bug...
…thub.com/onlimit-study/dmp into feat/create-overview-of-weeks-and-visits
lwjohnst86
requested changes
Aug 10, 2026
lwjohnst86
left a comment
lwjohnst86
left a comment
Member
There was a problem hiding this comment.
Nice updates
|
|
||
| This document explains how the study weeks, visits, and REDCap instruments | ||
| relate to each other within the feasibility study. The main study will have | ||
| included many of these details into the design of the REDCap. |
Member
There was a problem hiding this comment.
Suggested change
| included many of these details into the design of the REDCap. | |
| included many of these details into the design of REDCap. |
| will automatically create a new instance of the instrument for each time it is | ||
| set to be used in the Event planning. | ||
|
|
||
| | Weeks | Visit | Instrument name | |
Member
There was a problem hiding this comment.
Can you add the Phase ID/name as a column too?
| will automatically create a new instance of the instrument for each time it is | ||
| set to be used in the Event planning. | ||
|
|
||
| | Weeks | Visit | Instrument name | |
Member
There was a problem hiding this comment.
Can you create another column called like Repetition times or something similar? So that Instrument name directly maps to the actual name. And then move the (1. time) into the "repetition" column (as just a number)?
| instruments have a manually entered date field that is used to calculate the | ||
| week number. | ||
|
|
||
| | Instrument | Description | |
Member
There was a problem hiding this comment.
Can you add two new columns start_study_week and end_study_week, so that the week numbers are found in accessible columns rather than as text in a description?
| @@ -0,0 +1,88 @@ | |||
| Study week,Visit,Instrument name,Comments | |||
Member
There was a problem hiding this comment.
Please apply the same changes suggested above to here.
Comment on lines
+67
to
+88
| No week,,stamdata,"Running updates throughout weeks 1-52 | ||
| This form will contain basic information about the participant as well as information about drop-out or completion of study" | ||
| No week,,adverse_events,"Anytime throughout weeks 1-52 | ||
| This form will register any adverse event the participant experience throughout the study, the form has a date of completion and the dates of the event" | ||
| No week,,fase_1_ditetiske_afvigelser,"Anytime through weeks 1-11 | ||
| This form will register any deviation from the NUPO diet, the form has a date of completion and the dates of the event" | ||
| No week,,fase_2_ditetiske_afvigelser,"Anytime through weeks 12-18 | ||
| This form will register any deviation from the reintroduction of normal meals, the form has a date of completion and the dates of the event" | ||
| No week,,fase_3_ditetiske_afvigelser,"Anytime after week 18 | ||
| This form will register any deviation from the recommended diet, the form has a date of completion and the dates of the event" | ||
| No week,,trningsafvigelser,"Anytime after week 18 | ||
| This form will register any deviation from the recommended exercise, the form has a date of completion and the dates of the event" | ||
| No week,,ekstra_kontakt,"Anytime throughout weeks 1-52 | ||
| This form will capture any contact between study staff and the participant that falls outside the standard touch points. The form as a date for the contact and it is expected that the form is completed on the day of the contact." | ||
| No week,,hba1c_follow_up,"Anytime throughout weeks 1-52 | ||
| This form will register any extra HbA1c testing done at the lab if the study team suspects that there is a problem, the form as a date for the testing" | ||
| No week,,medicine_changes,"Anytime throughout weeks 1-52 | ||
| This form will register any changes to medicine during the study, the form has a date for the capture of the information" | ||
| No week,,individual_ditistsamtale_1,At some point between weeks 18 and 50 | ||
| No week,,individual_ditistsamtale_2,At some point between weeks 18 and 50 | ||
| No week,,individual_ditistsamtale_3,At some point between weeks 18 and 50 | ||
| No week,,individual_ditistsamtale_4,At some point between weeks 18 and 50 |
Member
There was a problem hiding this comment.
Please split this up into two files, one with the ongoing instruments and another with the scheduled instruments.
github-project-automation
Bot
moved this from In Review
to In Progress
in Data development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Very first draft of the description of the instrument and how they relate to weeks. I expect that there is a lot of questions that will arise from this.
I've avoided the whole making it a csv file for now by splitting the markdown table into two, it felt more important to get the text out for commenting than getting the repo to accept python code.
Closes #220
Needs a lot of comments on what I'm missing and what is unclear.
Checklist
just run-all