Alternative vocabulary: objective/constraint + severity (for discussion)

[geojaz]

Alternative vocabulary: objective / constraint + severity (for discussion)

Internal, for discussion, not headed upstream. This is the same verification work as #3 / #4, reworded from correctness / safety / catastrophic to two role polarities plus a severity, so we can look at the objective/constraint framing (raised on the scoring doc) in real code and decide whether it is worth adopting.

The reframe

• objective (must hold) feeds c (was correctness)
• constraint (a guardrail) with a severity:
  • recoverable feeds rec_v (was role safety)
  • catastrophic feeds cat_v (was role catastrophic)

So "catastrophic" stops being a third peer role and becomes a severity of a constraint. The formula and the c / rec_v / cat_v outputs are identical; only the vocabulary feeding them changes. 946 tests pass; the demo behaves identically.

Honest trade-offs (the decision this branch is meant to inform)

1. "constraint" collides with the existing schema. documentation entries already carry a constraints list (textual requirements for the judge). Reusing "constraint" as a verification role in the same YAML could confuse authors. The old names did not collide. If we like the polarity idea, a non-colliding word (guardrail?) may be better.
2. Rename only, not true negation. Every check here is still a must-hold predicate; a "constraint" passes when its guardrail holds. Genuinely expressing "must NOT hold" would need an explicit negate/forbidden option, a separate and larger change. This branch does the rename, not the polarity flip.
3. Severity is slightly more verbose. role=catastrophic (one self-describing field) becomes role=constraint, severity=catastrophic (two fields).

Status

Not for merge as-is. A vocabulary decision should follow the scoring-doc discussion. Opening here so we can compare both framings in real code side by side (#3 / #4 use the current names).

[gemini-code-assist]

Code Review

This pull request introduces a typed schema for verification entries, adds a scoring rollup mechanism, and implements new verifiers (HTTP probe and resource property). It also enhances the verifier agent with execution modes (converge, assert, hold) and improves error handling in verification mapping. My feedback suggests simplifying attribute access in the verifier agent and refactoring the HTTP probe's verify method to reduce code duplication.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The logic to get hold_window_sec and hold_interval_sec can be simplified. Since these attributes are defined on BaseVerifier with default float values, verifier nodes will always have them. You can use getattr with a default value to make this more concise.

Suggested change

	_window = getattr(node, "hold_window_sec", None)
	window_sec: float = _window if _window is not None else _DEFAULT_HOLD_WINDOW_SEC
	_interval = getattr(node, "hold_interval_sec", None)
	interval_sec: float = _interval if _interval is not None else _DEFAULT_HOLD_INTERVAL_SEC
	window_sec: float = getattr(node, "hold_window_sec", _DEFAULT_HOLD_WINDOW_SEC)
	interval_sec: float = getattr(node, "hold_interval_sec", _DEFAULT_HOLD_INTERVAL_SEC)

[gemini-code-assist]

The verify method can be refactored to reduce code duplication in creating VerificationResult instances within the try...except block. You can handle exceptions by setting the failure reason and then have a single VerificationResult creation at the end.

        start = time.monotonic()
        ok, reason, raw = False, "", None
        try:
            ok, reason, raw = self._run_probe()
        except SubprocessError as exc:
            stderr = (exc.stderr or "").strip()
            _log.warning("http_probe kubectl run failed for %s: %s", self.url, stderr)
            reason = f"kubectl run failed: {stderr}"
        except Exception as exc:  # noqa: BLE001 - surface unexpected errors as failures
            _log.warning("http_probe unexpected error for %s: %s", self.url, exc)
            reason = f"unexpected error: {exc}"

        return VerificationResult(
            success=ok,
            elapsed_time=time.monotonic() - start,
            reason=reason,
            name=self.name,
            raw=raw,
            weight=self.weight,
        )