Repository navigation
Conversation
… reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367. Related: #334.
Client::request()refreshes on any 401 and retries. Duringauthenticate()the resource listing is fetched with the token just obtained, so if Salesforce rejects that token (e.g. a Connected App without theapiscope →INVALID_SCOPES) the 401 triggersrefresh()→authenticate()again, and the process recurses until it runs out of memory.request()now refreshes at most once: a 401 raised while a refresh is in progress is rethrown instead of starting another one.TokenExpiredExceptionmessage, so the actual reason (INVALID_SCOPES,INVALID_SESSION_ID, …) is visible. Note: code matching the exact message stringSalesforce token has expiredwould need to usestr_starts_with.Adds a regression test for the OAuthJWT flow that fails without the fix.
This touches the same lines in
request()as #365; the two changes are independent and the conflict is trivial.