Add optional args param to build_url, make api_version optional - #5244
Merged
Conversation
Member
Author
|
--rebased-from #4744 |
Member
|
Merging per #5245 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Allows non-keyword args to be passed to
api.build_urlso absolute URLs can be constructed by omeroweb. In conjunction with #5245 this includes all required changes from #4744 (some commits were already rebased to develop, others are unnecessary following the addition ofomero.web.api.absolute_urlin mainline.Testing this PR
See #5245
Related reading
There was some discussion in Slack about how best to fix
build_url.@aleksandra-tarkowska @will-moore