[fix] Honor Omarchy terminal preference in xdg-terminal-exec - #172
Merged
Conversation
The factory shim always reported and launched Foot, so Setup → Defaults and Super+Return ignored ~/.config/xdg-terminals.list after Alacritty or Kitty was installed.
Collaborator
|
Hey, thanks for the PR. Codex: missing-terminal fallback is broken. Line 48 checks whether a command exists, but the Alacritty wrapper remains installed after the package is removed. I reproduced Super+Return exiting with “alacritty is not installed” instead of falling back to Foot. Kitty has the same problem when combined with #173. Check the underlying binary’s availability while retaining the wrapper for launching. |
Contributor
Author
|
@themartiano Should be in better shape now if you're able to review again. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/xdg-terminals.list; the factoryxdg-terminal-execshim always printed and launched Foot, so the Defaults menu (--print-id) and Super+Return never followed that list./usr/binpackage binary. Launching still uses the PATH-resolved wrapper so the VirGL graphics workaround remains active. It does not parse arbitrary user.desktopfiles.Existing VMs
Try Omarchy's factory image is a seed: installing a newer app does not rewrite a provisioned disk, so this overlay change does not land on an already-running guest by itself.
Foot still launches there, so the stub can be replaced in place without a factory reset. From a guest terminal, overwrite
/usr/local/bin/xdg-terminal-execwithguest/factory-overlay/usr/local/bin/xdg-terminal-execfrom this PR andchmod 0755it. Super+Return and Setup → Defaults then followxdg-terminals.list. A factory reset also picks it up on the next first boot.Test plan
make teston97f23f2: 103 guest Python tests, 242 Swift tests, and launcher checks pass. The staged-QEMU lock-inheritance test is skipped because this checkout has no staged QEMU binary.mainand resolved the executable-list and guest-verification conflicts./usr/local/bin/xdg-terminal-execwith the updated shim and confirm the same without factory resetFixes #169