Skip to content

Center list row icons and thumbnails at the smallest zoom - #212

Open
itscallssh wants to merge 1 commit into
omacom:mainfrom
itscallssh:fix/row-icon-centering-small-zoom
Open

itscallssh wants to merge 1 commit into
omacom:mainfrom
itscallssh:fix/row-icon-centering-small-zoom

Conversation

@itscallssh

Copy link
Copy Markdown
Contributor

Fix: list row icon alignment at the smallest zoom

At zoom 0.75 (24px rows), file and folder icons sat too low in their rows.

Cause

  • The tree-arrow spacer in FileRow was 32px tall, taller than a 24px row,
    which pushed all row content about 4px down.
  • Odd-sized boxes (a 12px glyph in a 15px picture box) were rounded twice in
    the same direction, leaving the icon 1px low. Zoom 1.25 had the same problem.

Change

  • The arrow spacer is now at most as tall as the row, so its click area is
    unchanged at larger zooms.
  • The picture box spans the row's full height, and the glyph is centered with
    exact arithmetic instead of anchors.centerIn.
  • Thumbnails stay snapped to whole pixels, so they stay sharp.

Result

Icons are centered vertically and horizontally at every zoom step
(0.75 to 2) and every display scale, in idle, hovered, active and cut states.
Spacing, animations and interactions are unchanged.

Now:
row-icon-alignment-before-after

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Centers list-row icons at the smallest zoom and avoids rounding their position twice.

  • File-row icons and thumbnails stay centered at every zoom.

No actionable issues were found. This review checked the source; it did not verify the rendered result.

Reviews (1) · Last reviewed commit: "Center list row icons and thumbnails at ..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant