Repository navigation
Center list row icons and thumbnails at the smallest zoom - #212
Open
itscallssh wants to merge 1 commit into
Open
itscallssh wants to merge 1 commit into
itscallssh wants to merge 1 commit into
Conversation
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryCenters list-row icons at the smallest zoom and avoids rounding their position twice.
No actionable issues were found. This review checked the source; it did not verify the rendered result. Reviews (1) · Last reviewed commit: "Center list row icons and thumbnails at ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: list row icon alignment at the smallest zoom
At zoom 0.75 (24px rows), file and folder icons sat too low in their rows.
Cause
FileRowwas 32px tall, taller than a 24px row,which pushed all row content about 4px down.
the same direction, leaving the icon 1px low. Zoom 1.25 had the same problem.
Change
unchanged at larger zooms.
exact arithmetic instead of
anchors.centerIn.Result
Icons are centered vertically and horizontally at every zoom step
(0.75 to 2) and every display scale, in idle, hovered, active and cut states.
Spacing, animations and interactions are unchanged.
Now:
