Repository navigation
Start a grid's band between tiles - #210
Merged
Merged
Conversation
In the grid, a selection rectangle could only start past the last tile. The band refused any press where the view had an item, and each tile owns its whole cell, padding included, with its tap and drag handlers covering all of it. So in a folder that fills the window there was almost nowhere to start a rectangle. Now a press is the tile's only on its drawn picture and name, the inset area the band already hits tiles with. The band refuses a press only there, and the tile's tap and drag handlers cover only that area, so a press in the padding falls through to the band. The list is unchanged: its rows' area is their whole width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryThe PR lets users start a selection rectangle between grid tiles.
Reviews (2) · Last reviewed commit: "Take presses on a tile's whole name" · Reviewed by Greptile |
A long name wraps to 14 pixels from the tile's sides, but presses (and the band's hits) began 20 pixels in, so a click on its outer letters cleared the selection instead of picking the file. Both now start where the name does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the grid, a selection rectangle could only start past the last tile. The band refused any press where the view had an item, and each tile owns its whole cell, padding included, with its tap and drag handlers covering all of it. So in a folder that fills the window there was almost nowhere to start a rectangle.
Now a press is the tile's only on its drawn picture and name, the inset area the band already hits tiles with. The band refuses a press only there, and the tile's tap and drag handlers cover only that area, so a press in the padding falls through to the band. The list is unchanged: its rows' area is their whole width.
No screenshots: it's an interaction. Press in the gap between two tiles and drag across them; on main nothing happens, now they're selected.
🤖 Generated with Claude Code