[WIP] Making access token management thread-safe#379
Open
Niccari wants to merge 5 commits into
Open
Conversation
- changed _credentials, fcm_end_point to cached propety, for better type hint - added non project_id unittest for BaseAPI
note: BaseAPI has been fixed in olucurious#376
Without this fix, calling refresh_token_if_expired() on a 401/ACCESS_TOKEN_EXPIRED response would clear _shared_token but not repopulate it, causing get_access_token() on the subsequent retry to perform an unnecessary second credentials.refresh(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Niccari
force-pushed
the
fix/shared_token_management
branch
from
8ea2901 to
cf3f33b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #378
Based: #377
To prevent inconsistencies in access token management, we have made it so that tokens are shared between threads.
Separated out the processes responsible for token management into TokenManager.
checks