Repository navigation
Aliquots list: move the pills into the results bar - #216
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From design review. Moves the two on/off pills out of the toolbar and into the bar directly above the table.
What changes (Aliquots list)
id="results-bar", and both pill links end in#results-bar, so toggling a pill leaves you at the results bar. The links still keep the other parameters and still go back to page 1._toggle_urlgained an optionalanchor.Checked out by me · 4). When it is on, the pill just says "Checked out by me". The accessible label always includes the count when the pill is off ("Checked out by me, 2 aliquots, off. Select to turn on"), so a screen reader loses nothing..toggle-pillgetsmin-height: 32px.Not changed
.results-infonow hasmargin-left: auto, so it is right-aligned with or without pills).Verification
sample/tests/test_results_bar.py(14 tests): the pills are in the results bar and not the toolbar; the order is pills, then count, then the view toggle; the bar's id; both toggle links end in the anchor and still keep the other parameters and droppage; turning a pill off keeps the list type and the anchor; the count shows only while the pill is off; the accessible label keeps the count; the chips row sits between the toolbar and the results bar and only when active; Clear all is in that row and not in the bar; the Samples list is unchanged; the bar exists on every list; and the CSS rules (32px, a wrapping centred row,margin-left: auto, no column stacking at narrow widths). Two older tests that checked the old pill text are updated. Full suite on the merged branch: 869 tests, OK. No migrations.🤖 Generated with Claude Code