Skip to content

Aliquots list: move the pills into the results bar - #216

Merged
olsonjp merged 4 commits into
mainfrom
results-bar-pills
Nov 11, 2026
Merged

olsonjp merged 4 commits into
mainfrom
results-bar-pills

Conversation

@olsonjp

@olsonjp olsonjp commented Nov 11, 2026

Copy link
Copy Markdown
Owner

From design review. Moves the two on/off pills out of the toolbar and into the bar directly above the table.

What changes (Aliquots list)

  • Pills in the results bar. Checked out by me and Hide exhausted now sit on the left of the results bar, directly above the table. The "N aliquots found" text and the list/grid toggle stay on the right. Everything shares one vertical centre line, and the bar wraps on narrow screens instead of stacking into a column.
  • Chips get their own row. The active-field chips and Clear all sit in their own row between the toolbar and the results bar, and appear only when something is active.
  • The page keeps its place. The results bar has id="results-bar", and both pill links end in #results-bar, so toggling a pill leaves you at the results bar. The links still keep the other parameters and still go back to page 1. _toggle_url gained an optional anchor.
  • The count shows in the Checked out pill only while it is off (Checked out by me · 4). When it is on, the pill just says "Checked out by me". The accessible label always includes the count when the pill is off ("Checked out by me, 2 aliquots, off. Select to turn on"), so a screen reader loses nothing.
  • Pills are at least 32px tall. The shared .toggle-pill gets min-height: 32px.

Not changed

  • The Samples list keeps its Low count pill under its search card. Its results bar has no pills and the count and view toggle stay right-aligned (.results-info now has margin-left: auto, so it is right-aligned with or without pills).
  • Filtering, chips, Clear all and the pills' behaviour are unchanged.

Verification

  • sample/tests/test_results_bar.py (14 tests): the pills are in the results bar and not the toolbar; the order is pills, then count, then the view toggle; the bar's id; both toggle links end in the anchor and still keep the other parameters and drop page; turning a pill off keeps the list type and the anchor; the count shows only while the pill is off; the accessible label keeps the count; the chips row sits between the toolbar and the results bar and only when active; Clear all is in that row and not in the bar; the Samples list is unchanged; the bar exists on every list; and the CSS rules (32px, a wrapping centred row, margin-left: auto, no column stacking at narrow widths). Two older tests that checked the old pill text are updated. Full suite on the merged branch: 869 tests, OK. No migrations.
  • Not checked by me: how it looks in a browser. The alignment of the bar, how it wraps at narrow widths, and that toggling a pill leaves you at the results bar need a look.

🤖 Generated with Claude Code

olsonjp and others added 4 commits November 11, 2026 11:02
…storage and consumables forms; singular filter

Closes #207.
Closes #209.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@olsonjp
olsonjp merged commit 8b26786 into main Nov 11, 2026
1 check passed
@olsonjp
olsonjp deleted the results-bar-pills branch November 11, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant