Repository navigation
Search the Aliquots and Samples lists by field - #214
Merged
Merged
Conversation
Closes #211. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211
Follow-up for the other lists: #213
What it does
:has()), and opens by itself when one of its fields is in use. It holds Lab member, Date from and Date to (native date pickers, dark-mode aware), Location, Aliquot number, Disposition and Type, each with a one-line hint. Disposition and Type moved here from the toolbar.p8does not matchp80). A trailing*matches the start (P8*). The rule is in the input's tooltip and repeated at the top of the More panel.#. Dates: from means on or after, to means on or before, the same date in both means that day. Aliquots with no sample date are never in a range, and the page says how many were left out.hela p8works. "Quoted words" keep the old single-phrase behaviour. The Samples, Sources and Aliquot Types search boxes split words too.f_sample,f_passage,f_member,f_date_from,f_date_to,f_location,f_number(and the existingdisposition,aliquot_type,q); treat them as stable.FilterSpec(sample/list_filters.py); the query filters, inputs, chips and suggestions all come from it, through two shared partials. Another list adopts it by writing a spec.{# #}that was rendering as visible text is now a{% comment %}block. It was the only one in the project, and a test guards the filter templates.krill/sample/README.mdexplains searching by field, linked fromdocs/README.md.Decisions to check
*for a prefix), following the design notes, not "contains".:has()(current browsers).Verification
sample/tests/test_field_filters.py(55 tests): each field and its rule (passage exact vs*, member by name and initials, location, number, the date range edges and the no-date note), AND across fields, search-everything words and quotes, chips and Clear all (what each removes, what is kept), the More panel (what is in it, when it opens, the count), the toolbar order and header, the empty-result links, and the Samples list. Full suite: 827 tests, OK. No migrations.🤖 Generated with Claude Code