Repository navigation
Check out from the Aliquots list; Lab Checkouts tile; in-page confirm dialog - #204
Merged
Merged
Conversation
… dialog Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #202 and #203 for #192. This is not a lab-feedback issue. It comes from the design review of the checkout workflow.
What it does
checked_out_by=all: everyone's checked-out aliquots, grouped by person (username, then newest first), with Checked Out By and Checked Out columns and a "Checked out by anyone" chip. A column sort overrides the grouping. Members cannot useall; it is ignored for them.confirm()popup, which felt like an error. Same message text and the same two clicks, in a dialog styled like the app (dark mode included, Esc or the backdrop cancels), with a button that names the action. It is one shared script,static/krill/js/confirm-dialog.js: adddata-confirm="..."to a form. Converted: Check out (list and the aliquot's own page), Done (Dashboard), and Apply on the no-owner report. The other native confirms (revoke permission, report retry and duplicate, alert and issue acknowledge and resolve) are left as they are.Behaviour changes to know about
nextfor same-site addresses, using Dashboard: checked-out card with Create child and Done #203'ssafe_next. Without it, it still goes to the aliquot page..btn-plain(used by Done) moved fromhome.htmlinto the shared stylesheet so the list button matches.Not changed
The "tube" wording in the Samples and Aliquots list hints is older than this work and is left alone.
Verification
sample/tests/test_checkout_from_list.py(button on stored rows only, return to the list, foreignnextignored, the stale-checkout guard, box position freed, theallfilter and its member restriction and grouping, the tile and its counts, the confirm markup and escaping) and one inreports/test_checked_out_no_owner.py. Full suite: 641 tests, OK. No migrations.alllist have not been looked at.🤖 Generated with Claude Code