Skip to content

Sample page: remaining aliquots; aliquot page: Create child and lineage - #201

Merged
olsonjp merged 1 commit into
mainfrom
sample-remaining-aliquots-child-button
Nov 11, 2026
Merged

olsonjp merged 1 commit into
mainfrom
sample-remaining-aliquots-child-button

Conversation

@olsonjp

@olsonjp olsonjp commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Closes #193
Closes #194

#194: remaining aliquots on the sample page

  • The sample page has a Remaining aliquots (N) table: aliquot link, type, passage, sample date, location.
  • All aliquots of this sample opens the Aliquots list filtered to that sample.
  • To make that link exact, the Aliquots list has a new sample=<id> filter with a removable chip. Searching by name would also match other samples (for example "Test Sample" matches "Test Sample 2") and notes.

#193: Create child aliquot

  • Create child aliquot button on both aliquot pages (the read-only page and the Edit / Move / Check Out page).
  • It opens create/?type=aliquot&parent=<id> with Parent and Sample filled in. A missing or invalid parent is ignored.
  • Both pages have a new Lineage section showing the parent and the children as links. Neither showed lineage before.
  • After saving, the create form goes to the Aliquots list as before. The new aliquot is stored with parent set, so it shows under the original.

How I read the ambiguous parts

  • "Remaining" = disposition Stored and a box position, as Show a sample's remaining aliquots on its page #194 says. This is still to be confirmed with the lab. A Stored aliquot with no box position would not be listed or counted.
  • The form only prefills parent and sample. Type, passage and the rest are left for the person to fill in.

Verification

  • New tests in sample/tests/test_lineage_and_remaining.py (14) cover prefill, bad parent values, creating a child, the button and lineage on both pages, what counts as remaining, and the sample filter. Full suite: 567 tests, OK.
  • I cannot see the browser; the author reviewed the layout locally and the formatting was adjusted from their feedback. I did not re-run the full suite after the last CSS-only tweaks (link styling and the table style); I re-ran the 14 new tests.

🤖 Generated with Claude Code

Closes #193, #194.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@olsonjp
olsonjp merged commit b36233a into main Nov 11, 2026
1 check passed
@olsonjp
olsonjp deleted the sample-remaining-aliquots-child-button branch November 11, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show a sample's remaining aliquots on its page Add a "Create child aliquot" button on the aliquot page

1 participant