Repository navigation
Sample page: remaining aliquots; aliquot page: Create child and lineage - #201
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193
Closes #194
#194: remaining aliquots on the sample page
sample=<id>filter with a removable chip. Searching by name would also match other samples (for example "Test Sample" matches "Test Sample 2") and notes.#193: Create child aliquot
create/?type=aliquot&parent=<id>with Parent and Sample filled in. A missing or invalidparentis ignored.parentset, so it shows under the original.How I read the ambiguous parts
Verification
sample/tests/test_lineage_and_remaining.py(14) cover prefill, bad parent values, creating a child, the button and lineage on both pages, what counts as remaining, and the sample filter. Full suite: 567 tests, OK.🤖 Generated with Claude Code