Skip to content

Add Experiment field to Create/Edit Sample form #92

Closed

Description

@olsonjp

Source: docs/IMPLIED_FUNCTIONALITY_BROWSER_QA.md §3.1

Finding: The Sample model has an experiment field (TextField(blank=True, null=True)) and the sample detail page displays it (e.g. "Experiment: EXP_W21B"), but the Create Sample form and the sample detail Edit form only show Name, Source, Notes, and Access level. Users cannot set or change experiment from the UI.

Where:

  • krill/sample/forms.py — SampleForm has fields = ['name', 'source', 'notes', 'access_level']
  • Sample model: krill/sample/models/sample.py — experiment = models.TextField(blank=True, null=True)

Recommendation: Add experiment to SampleForm.Meta.fields (and ensure create/edit templates render it) so users can optionally set or change experiment; keep it optional to match the model.

Activity

  1. olsonjp commented on Nov 10, 2026

    @olsonjp
    OwnerAuthor

    Already in place: experiment is in SampleForm and renders on the create and edit pages. #186 added tests that lock it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions