Skip to content

[WIP] Improve LSP support#43

Open
AlexBeauchemin wants to merge 6 commits intoolivercederborg:mainfrom
AlexBeauchemin:improve-lsp-colors
Open

[WIP] Improve LSP support#43
AlexBeauchemin wants to merge 6 commits intoolivercederborg:mainfrom
AlexBeauchemin:improve-lsp-colors

Conversation

@AlexBeauchemin
Copy link
Copy Markdown

@AlexBeauchemin AlexBeauchemin commented May 9, 2024

Work in progress

See this thread for more info: #39 (comment)

I'm not sure if this is the correct way to address colors becoming "off" once LSP kicks in though, but it works.

  • Improve lsp colors (typescript)
  • Improve lsp colors (typescriptreact / tsx)
  • Improve lsp colors (lua)
  • Add nvim-dashboard support (lazyvim)
  • Improve neotree support
  • Improve border contrast with transparent background on floating windows (lazygit)

TODO: Provide screenshots of the difference

@1999shaswat
Copy link
Copy Markdown

1999shaswat commented Feb 23, 2025

@AlexBeauchemin Just installed your fork. It works flawlessly. You are god sent! Thanks a lot!!
OLD
OLD
NEW
NEW

@olivercederborg
Copy link
Copy Markdown
Owner

@AlexBeauchemin is this still a WIP PR?

@AlexBeauchemin
Copy link
Copy Markdown
Author

@olivercederborg I eventually switched to a different colorscheme so stopped working on it, but, while not perfect, I used this for a while and it was good enough (in my opinion)

I'll let you decide if you want to merge/include those changes or not
While this can be polished, I think it's still a net improvement on the current state of the colorscheme (nothing against you or your implementation, just adding a sane default when the LSP kicks in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants