Prod Release Monday Sep 15 by tellmeY18 · Pull Request #3263 · ohcnetwork/care

tellmeY18 · 2025-09-15T17:25:22Z

Proposed Changes

Brief of changes made.

Associated Issue

Link to issue here, explain how the proposed solution will solve the reported issue/ feature request.

Architecture changes

Remove this section if not used

Merge Checklist

Tests added/fixed
Update docs in /docs
Linting Complete
Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

…/labs

* Adds filters for dispense status in Medication Request ViewSet * Add for request summary * add exclude status filter for medication dispense

…3065) * Update inventory item net content filter to allow filtering by range * weird things...

…gneshhari/labs

Bumps [djangorestframework](https://github.com/encode/django-rest-framework) from 3.15.2 to 3.16.1. - [Release notes](https://github.com/encode/django-rest-framework/releases) - [Commits](encode/django-rest-framework@3.15.2...3.16.1) --- updated-dependencies: - dependency-name: djangorestframework dependency-version: 3.16.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat:implemented testcases for create healthcare service request * feat:implemented testcases for retrieve healthcare service request * feat:implemented testcases for update healthcare service request * feat:implemented testcases for filtering healthcare service request * feat:added some edge cases --------- Co-authored-by: Aakash Singh <mail@singhaakash.dev>

Bumps [pillow](https://github.com/python-pillow/Pillow) from 11.1.0 to 11.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@11.1.0...11.3.0) --- updated-dependencies: - dependency-name: pillow dependency-version: 11.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add location in dispense read spec * Lint fix

Bumps [celery](https://github.com/celery/celery) from 5.4.0 to 5.5.3. - [Release notes](https://github.com/celery/celery/releases) - [Changelog](https://github.com/celery/celery/blob/main/Changelog.rst) - [Commits](celery/celery@v5.4.0...v5.5.3) --- updated-dependencies: - dependency-name: celery dependency-version: 5.5.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refact:fixed facility check * removed unwanted facility call

Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 4.0.1 to 4.3.0. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v4.0.1...v4.3.0) --- updated-dependencies: - dependency-name: pre-commit dependency-version: 4.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat:added test cases for create product knowledge * feat:added testcases for retrieve product knowledge * feat:added update product knowledge testcases * feat:added testcases for listing product knowledge * feat:added testcases for listing product knowledge * feat:added testcases for validation * feat:added slug validation

Bumps [mypy](https://github.com/python/mypy) from 1.14.1 to 1.17.1. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.14.1...v1.17.1) --- updated-dependencies: - dependency-name: mypy dependency-version: 1.17.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* using enum choice in resource request * added created date and modified date in service request

* feat:added setup for identifier config * feat:added create testcases for patient identifier * feat:added retrieve testcases for patient identifier * feat:added update testcases for patient identifier * feat:added list testcases for patient identifier * minor change * refact:fixed facility check --------- Co-authored-by: Aakash Singh <mail@singhaakash.dev> Co-authored-by: Prafful Sharma <115104695+praffq@users.noreply.github.com>

* feat:added a helper function for service request * feat: test cases for specimen --------- Co-authored-by: Aakash Singh <mail@singhaakash.dev> Co-authored-by: Prafful Sharma <115104695+praffq@users.noreply.github.com>

Bumps [jsonschema](https://github.com/python-jsonschema/jsonschema) from 4.23.0 to 4.25.1. - [Release notes](https://github.com/python-jsonschema/jsonschema/releases) - [Changelog](https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst) - [Commits](python-jsonschema/jsonschema@v4.23.0...v4.25.1) --- updated-dependencies: - dependency-name: jsonschema dependency-version: 4.25.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.11.7 to 0.12.12. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.11.7...0.12.12) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.12.12 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [redis-om](https://github.com/redis/redis-om-python) from 0.3.3 to 0.3.5. - [Release notes](https://github.com/redis/redis-om-python/releases) - [Commits](redis/redis-om-python@v0.3.3...v0.3.5) --- updated-dependencies: - dependency-name: redis-om dependency-version: 0.3.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

+                self.get_facility_from_instance(instance),
+            )
+        except ValueError as e:
+            raise RestFrameworkValidationError(str(e)) from e


To fix this issue, do not expose the actual content of the caught ValueError to the API consumer. Instead, raise a RestFrameworkValidationError with a safe, generic error message. The original exception e can optionally be logged server-side for troubleshooting if needed. The change should only be made to line 351, within the perform_set_tags method inside the EMRTagMixin class in care/emr/api/viewsets/base.py. No new methods or models are required, but a logging import (import logging) is recommended if server-side logging is desirable—and that logging code should be added right before the safe error message is raised. This ensures the user sees only a generic error and the developer still has diagnostics.

coderabbitai · 2025-09-15T17:25:30Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vigneshhari and others added 30 commits May 21, 2025 01:19

Added Base for patient identifiers, Fix bugs

5191a3a

Fix issues with observation definition and account spec

503c215

Make dispense dosage same as request

c019e8f

Adds Patient Indentifier Config and Filters for supply delivery

88e108c

Fix account filter for facility

4ab1c66

Render Patient Identifier Configs

c9bd07e

Fix inventory summarization

94a6b0f

Add patient identifier API's

4a0205c

Merge branch 'develop' of github.com:ohcnetwork/care into vigneshhari…

89f311c

…/labs

Merge branch 'develop' of github.com:ohcnetwork/care into vigneshhari…

a32f172

…/labs

Fix merge migrations

4c89870

Fix inventory syncing

eae4603

Added encounter class filter to medication request

d1caeb5

Better Upsert validations, fix issues

47d07f6

Enhances invoices, and adds product support in administration

296e1a8

Move issue date to issue datetime

ca6dc1b

Add priority filter for medication request

3df8308

Fix Validations in account, pre commit changes

f4e48e4

Fix validations

0c86b09

Cancelling invoice will move charge_items to billable

df6929a

Fix stupid bug

5ae8b40

Adds dispense status filters for medication request viewset (#3055)

b3eaef0

* Adds filters for dispense status in Medication Request ViewSet * Add for request summary * add exclude status filter for medication dispense

Add Tag Config API's and other filters

24694f7

Update inventory item net content filter to allow filtering by range (#…

e18ec0f

…3065) * Update inventory item net content filter to allow filtering by range * weird things...

Added tagging v0.1

867efec

Merge branch 'vigneshhari/labs' of github.com:ohcnetwork/care into vi…

4337689

…gneshhari/labs

Slightly redesign tags

7e5203b

Redesigning Tags

0506a36

Cleaning up tags

c90f3fb

Fix patients API

d583df3

vigneshhari and others added 25 commits August 18, 2025 14:19

Support managing organization in healthcare service

22e9eeb

Fixed issue with encounter

1aad446

Add requestor for service request

34c0e5b

refact: facility identifier check in the spec mapping (#3207)

5bf4a91

Adds support for upsert on charge item definition and product (#3211)

6d3cec9

Fix reported issues

7aaaf5f

Merge branch 'develop' of github.com:ohcnetwork/care into develop

7f40883

add requester in AD apply spec

5db4106

add upsert mixins to activity, observation, specimen def (#3213)

563bc37

Add location in dispense read spec (#3218)

6c5ede6

* Add location in dispense read spec * Lint fix

refact:fixed facility check (#3209)

6dd3985

* refact:fixed facility check * removed unwanted facility call

Add configuration for testing integration in vscode (#3225)

78d3cb7

using enum choice in resource request (#3217)

b3878ef

* using enum choice in resource request * added created date and modified date in service request

Api test cases for specimen viewset (#3113)

c309d55

* feat:added a helper function for service request * feat: test cases for specimen --------- Co-authored-by: Aakash Singh <mail@singhaakash.dev> Co-authored-by: Prafful Sharma <115104695+praffq@users.noreply.github.com>

tellmeY18 requested a review from a team as a code owner September 15, 2025 17:25

github-advanced-security AI found potential problems Sep 15, 2025

View reviewed changes

gigincg changed the title ~~10bedicu Prod Release Monday Sep 15~~ Prod Release Monday Sep 15 Sep 15, 2025

gigincg closed this Sep 16, 2025

@@ -348,8 +348,12 @@
                             self.get_facility_from_instance(instance),
                         )
                     except ValueError as e:
-                        raise RestFrameworkValidationError(str(e)) from e
+                        # Log exception on server side, send generic message to user
+                        import logging
+                        logging.exception("Error setting tags")
+                        raise RestFrameworkValidationError(
+                            "There was an error processing tags. Please check your request and try again."
+                        ) from e
                 @extend_schema(request=TagRequest)
                 @action(detail=True, methods=["POST"])
                 def set_tags(self, request, *args, **kwargs):

Navigation Menu

Prod Release Monday Sep 15 - #3263

Prod Release Monday Sep 15#3263
tellmeY18 wants to merge 365 commits into
data-migrationfrom
develop

tellmeY18 commented Sep 15, 2025

Uh oh!

Check warning

Copilot Autofix

coderabbitai Bot commented Sep 15, 2025

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

tellmeY18 commented Sep 15, 2025

Proposed Changes

Associated Issue

Architecture changes

Merge Checklist

Uh oh!

Check warning

Uh oh!

Copilot Autofix

coderabbitai Bot commented Sep 15, 2025

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants