Add live GitHub star count to the site - #46
Merged
Conversation
The repository star count now appears in the header and in the closing call to action. The number is rendered into the markup at build time, so it is correct with JavaScript disabled and the button never changes width after load; script.js only refreshes it from api.github.com and caches the answer for six hours. Any failure leaves the shipped number in place. Also in this pass: - cooling-v16.png was the one image on the page with no intrinsic size in either the markup or the stylesheet, so it was shifting layout as it loaded. It now carries width and height. - Headings balance their last line and the main body copy uses text-wrap: pretty, so single words stop stranding. - connect-src in the CSP is widened to api.github.com and nothing else.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository star count now appears in the header and in the closing call to action. The number is rendered into the markup at build time, so it is correct with JavaScript disabled and the button never changes width after load; script.js only refreshes it from api.github.com and caches the answer for six hours. Any failure leaves the shipped number in place.
Also in this pass:
Change
Describe the problem and the change.
Verification
List the checks you ran.