Repository navigation
Add Wave 1-3 toolkit enhancements: workbook parser dependsOn, NRT/lookback defaults, local XDR validators, and lab ARM preflight - #5
Merged
oferInbar merged 5 commits intoOct 14, 2026
Conversation
…, validation, and CLI UX
- Emit canonical [variables('parserObject<N>')._parserId<N>] in Defender Workbook dependsOn and verify in packaging.py
- Default 1h (PT1H) Sentinel rules to native 4h (PT4H) XDR lookback with recorded eventTimeWindow provenance
- Map eligible kind: NRT rules to Continuous (NRT) Custom Detections and flag incompatible NRT queries for review
- Accept standard _-prefixed built-in ASIM parsers (_ASim_*, _Im_*) in Custom Detections and Defender Workbooks
- Inherit solution release version in [3.1.0, 4.0.0) and preserve lexical source YAML version text
- Add XDR Detection and Defender Workbook validators to .script/local-validation/ with explicit SKIP reporting
- Add consolidated review-packet CLI subcommand, nextStepRecommendation summaries, and DD-MM-YYYY default release-note dates
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
…cution leases, and approval forwarding Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
…nge check in local validators Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
…tions - Emit schedule.frequency: PT0S for eligible single-table Continuous (NRT) rules - Normalize legacy schedule.frequency: NRT to PT0S in Graph payloads and V3.1 ARM packaging - Verified against Microsoft.Security/detectionRules@2026-06-01-preview in live Azure deployment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
dependsOnreferences ([variables('parserObject<N>')._parserId<N>]) for Defender Workbooks incommon/defenderWorkbooks.ps1andpackaging.py.PT1Hfrequency andPT1Hlookback) to the native 4-hour XDR lookback (PT4H) witheventTimeWindowprovenance, map eligible single-tablekind: NRTrules toschedule.frequency: "NRT", accept standard_-prefixed built-in ASIM parsers (_ASim_*and_Im_*) in both Custom Detections and Defender Workbooks, and inherit the solution release version in[3.1.0, 4.0.0)while preserving lexical source YAML version strings..script/local-validation/validate-xdr-content.pyand integratexdr-detectionandxdr-workbookvalidators into.script/local-validation/validate.tsandbuild-and-validate.ps1with explicitSKIPvisibility.review-packet,consolidated-review-plan), focused next-blocker guidance (nextStepRecommendation,nextBlockerReview), predictableDD-MM-YYYYrelease-note dates (release_notes.py), defaultlab-deploymentARM validation preflight (X Sentinel rules, Y workbooks, and Z custom detections), qualification/export readiness audits, status reminders (workflow-status-reminder), single-owner execution leases (workflow-execution-owner), and explicit approval forwarding (workflow-forward-approval).Reason for Change(s):
Solution-toolkit-master.Version Updated:
Solutions/content files modified on this branch)Testing Completed:
PYTHONPATH=Tools/SentinelToXDRMigration:Tools/SentinelToXDRMigration/tests /opt/anaconda3/bin/python3.12 -m pytest -q Tools/SentinelToXDRMigration/testsResult: passed (
1471 passed, 9 skipped, 2 warnings in 485.37s)pwsh -NoProfile -Command "Invoke-Pester -Path 'Tools/SentinelToXDRMigration/tests/defenderWorkbooks.Tests.ps1'"Result: passed (
25 passed, 0 failed)security-reviewagent across5de0ccd73ad299a59c0ef2572726bf1c82bdd0e5..1e883a9b54c31244d0e17466da2383bb9dfcbc49):Result: passed (0 vulnerabilities found)
Checked that the validations are passing and have addressed any issues that are present: