Repository navigation
Add Defender Workbook migration, provenance, and Wave 1-3 workflow enhancements - #4
Merged
oferInbar merged 14 commits intoOct 14, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Import a bounded Microsoft MIT shared conversion slice with package-local catalogs, complete Notebook preservation, reviewed query resolutions, stable identities, explicit prerequisites, and offline fixture contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Emit independent workbook installation and Content Hub registration with resolved package provenance, reviewed source/query freshness and source-preserving projections. Keep provider acceptance unverified and legacy ARM-TTK defaults intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Separate generated candidates from package acceptance, preserve legacy validation, and require exact approved scope, durable attempts and independent workbook contract evidence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Compare required input identity fields while independently verifying the complete production file manifest; reject absent, incomplete or stale manifests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Separate workbook-only static validation from post-installation qualification. Preserve detection runtime prerequisites and legacy reporting; document candidate acceptance, verified browser evidence and unresolved production provider boundaries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Treat workbook and XDR detection overwrites as normal managed upserts, including in labs. Preserve target, consent, disabled-content and post-write acceptance boundaries; distinguish personalization copies and local-file safeguards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Bind metadata reads to explicit scope consent, verify observed ARM identity and control-plane access, and preserve managed same-ID update semantics. Keep unverified MicrosoftSecurity contracts blocked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Apply the solution-only release floor to Authoring targets, release planning, workbook selection and local/pipeline packaging. Preserve independent content-version bounds and reject invalid effective releases before mutation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
…y scanning - Add workbook dependency planning, static/lab review, and workspace function hash binding - Harden Python and PowerShell workbook KQL scanners against escaped/quoted function call and table-reference bypasses - Document standard _-prefixed built-in ASIM parser support and consolidated one-shot review preferences Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
workbook-dependency-plan,workbook-review), and V3.1 packaging (common/defenderWorkbooks.ps1) with canonical parserdependsOnreferences ([variables('parserObject<N>')._parserId<N>]).3.2.0 <= version < 4.0.0for current Authoring target/release selection and V3.1 packaging while preserving Custom Detection release bounds[3.1.0, 4.0.0)and solution release version inheritance.PT1Hfrequency andPT1Hlookback) to the native 4-hour XDR lookback (PT4H) witheventTimeWindowprovenance, map eligible single-tablekind: NRTrules toschedule.frequency: "NRT", and accept standard_-prefixed built-in ASIM parsers (_ASim_*and_Im_*) in both Custom Detections and Defender Workbooks..script/local-validation/validate-xdr-content.pyand integratexdr-detectionandxdr-workbookvalidators into.script/local-validation/validate.tsandbuild-and-validate.ps1with explicitSKIPvisibility.review-packet,consolidated-review-plan), focused next-blocker guidance (nextStepRecommendation,nextBlockerReview), predictableDD-MM-YYYYrelease-note dates (release_notes.py), defaultlab-deploymentARM validation preflight (X Sentinel rules, Y workbooks, and Z custom detections), qualification/export readiness audits, status reminders (workflow-status-reminder), single-owner execution leases (workflow-execution-owner), and explicit approval forwarding (workflow-forward-approval).Reason for Change(s):
Solution-toolkit-masterwithout modifying solution content files on the toolkit branch.Version Updated:
Solutions/content files modified on this branch)Testing Completed:
PYTHONPATH=Tools/SentinelToXDRMigration:Tools/SentinelToXDRMigration/tests /opt/anaconda3/bin/python3.12 -m pytest -q Tools/SentinelToXDRMigration/testsResult: passed (
1471 passed, 9 skipped, 2 warnings in 485.37s)pwsh -NoProfile -Command "Invoke-Pester -Path 'Tools/SentinelToXDRMigration/tests/defenderWorkbooks.Tests.ps1'"Result: passed (
25 passed, 0 failed)security-reviewagent across8d08428cab0f981a65804ff42cb7ec61c5e04a26..1e883a9b54c31244d0e17466da2383bb9dfcbc49):Result: passed (0 vulnerabilities found)
Checked that the validations are passing and have addressed any issues that are present: