Skip to content

Add Defender Workbook migration, provenance, and Wave 1-3 workflow enhancements - #4

Merged
oferInbar merged 14 commits into
Solution-toolkit-masterfrom
solution-toolkit-defender-wbs
Oct 14, 2026
Merged

oferInbar merged 14 commits into
Solution-toolkit-masterfrom
solution-toolkit-defender-wbs

Conversation

@oferInbar

@oferInbar oferInbar commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Required items, please complete

Change(s):

  • Add first-class Defender Workbook migration, dependency planning/review (workbook-dependency-plan, workbook-review), and V3.1 packaging (common/defenderWorkbooks.ps1) with canonical parser dependsOn references ([variables('parserObject<N>')._parserId<N>]).
  • Enforce solution release floor 3.2.0 <= version < 4.0.0 for current Authoring target/release selection and V3.1 packaging while preserving Custom Detection release bounds [3.1.0, 4.0.0) and solution release version inheritance.
  • Default hourly Sentinel rules (PT1H frequency and PT1H lookback) to the native 4-hour XDR lookback (PT4H) with eventTimeWindow provenance, map eligible single-table kind: NRT rules to schedule.frequency: "NRT", and accept standard _-prefixed built-in ASIM parsers (_ASim_* and _Im_*) in both Custom Detections and Defender Workbooks.
  • Add .script/local-validation/validate-xdr-content.py and integrate xdr-detection and xdr-workbook validators into .script/local-validation/validate.ts and build-and-validate.ps1 with explicit SKIP visibility.
  • Add consolidated batch review helpers (review-packet, consolidated-review-plan), focused next-blocker guidance (nextStepRecommendation, nextBlockerReview), predictable DD-MM-YYYY release-note dates (release_notes.py), default lab-deployment ARM validation preflight (X Sentinel rules, Y workbooks, and Z custom detections), qualification/export readiness audits, status reminders (workflow-status-reminder), single-owner execution leases (workflow-execution-owner), and explicit approval forwarding (workflow-forward-approval).

Reason for Change(s):

  • Enable end-to-end Sentinel-to-Defender-XDR solution authoring, workbook migration, dependency provenance, consolidated batch review, and V3.1 hybrid solution packaging on Solution-toolkit-master without modifying solution content files on the toolkit branch.

Version Updated:

  • N/A (toolkit and local-validation infrastructure only; zero Solutions/ content files modified on this branch)

Testing Completed:

  • Yes
  • Full Python test suite:
    PYTHONPATH=Tools/SentinelToXDRMigration:Tools/SentinelToXDRMigration/tests /opt/anaconda3/bin/python3.12 -m pytest -q Tools/SentinelToXDRMigration/tests
    Result: passed (1471 passed, 9 skipped, 2 warnings in 485.37s)
  • PowerShell V3.1 Defender Workbook packaging & parser dependency tests:
    pwsh -NoProfile -Command "Invoke-Pester -Path 'Tools/SentinelToXDRMigration/tests/defenderWorkbooks.Tests.ps1'"
    Result: passed (25 passed, 0 failed)
  • Security review (security-review agent across 8d08428cab0f981a65804ff42cb7ec61c5e04a26..1e883a9b54c31244d0e17466da2383bb9dfcbc49):
    Result: passed (0 vulnerabilities found)

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

oferInbar and others added 14 commits October 13, 2026 14:24
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Import a bounded Microsoft MIT shared conversion slice with package-local catalogs, complete Notebook preservation, reviewed query resolutions, stable identities, explicit prerequisites, and offline fixture contracts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Emit independent workbook installation and Content Hub registration with resolved package provenance, reviewed source/query freshness and source-preserving projections. Keep provider acceptance unverified and legacy ARM-TTK defaults intact.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Separate generated candidates from package acceptance, preserve legacy validation, and require exact approved scope, durable attempts and independent workbook contract evidence.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Compare required input identity fields while independently verifying the complete production file manifest; reject absent, incomplete or stale manifests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Separate workbook-only static validation from post-installation qualification. Preserve detection runtime prerequisites and legacy reporting; document candidate acceptance, verified browser evidence and unresolved production provider boundaries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Treat workbook and XDR detection overwrites as normal managed upserts, including in labs. Preserve target, consent, disabled-content and post-write acceptance boundaries; distinguish personalization copies and local-file safeguards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Bind metadata reads to explicit scope consent, verify observed ARM identity and control-plane access, and preserve managed same-ID update semantics. Keep unverified MicrosoftSecurity contracts blocked.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Apply the solution-only release floor to Authoring targets, release planning, workbook selection and local/pipeline packaging. Preserve independent content-version bounds and reject invalid effective releases before mutation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
…y scanning

- Add workbook dependency planning, static/lab review, and workspace function hash binding
- Harden Python and PowerShell workbook KQL scanners against escaped/quoted function call and table-reference bypasses
- Document standard _-prefixed built-in ASIM parser support and consolidated one-shot review preferences

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
@oferInbar
oferInbar merged commit 28bf106 into Solution-toolkit-master Oct 14, 2026
@oferInbar oferInbar changed the title Add workbook migration and enforce solution releases from 3.2.0 Add Defender Workbook migration, dependency provenance, and V1 PREVIEW follow-ups to Sentinel-to-XDR toolkit Oct 14, 2026
@oferInbar oferInbar changed the title Add Defender Workbook migration, dependency provenance, and V1 PREVIEW follow-ups to Sentinel-to-XDR toolkit Add Defender Workbook migration, provenance, and Wave 1-3 workflow enhancements Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant