Repository navigation
cisco 3.1.3 - #3
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
oferInbar
marked this pull request as ready for review
October 13, 2026 14:23
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d48e2ad-f67d-4314-b990-7eb2db60a695
Owner
Author
|
Resolved the merge conflicts against the fork's master branch. The tested CiscoASA 3.1.3 release files are unchanged; the earlier 3.1.2 ZIP and all other solutions are retained. Fresh XDR structural validation passes for all three detections. The previously reported ARM-TTK provenance packageId finding remains unresolved; this merge does not establish release readiness or live Graph/Content Hub support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
contentProvenance.requiredWorkloads(sentinel,CommonSecurityLog) andrequiredDataConnectors(CiscoAsaAma,CommonSecurityLog).3.1.3.zip. Installation and stored-installation records carry matching package/content identifiers and versions; Content Hub registration also carries the authored prerequisites.Reason for Change(s):
IDs Should Be Derived From ResourceIDsrejects literal provenancepackageIdvalues. No validator was waived and no implementation workaround was applied.master: this branch started from the target worktree's older base. Base reconciliation is still required; unrelated dirty worktree content has not been stashed or reset.Version Updated:
Testing Completed:
Offline Authoring only. No live Sentinel or Advanced Hunting queries, deployments, ingestion, activation, or alert-parity tests were run. Live Graph/Content Hub acceptance remains unverified.
XDR structural validation: passed, 3 valid and 0 invalid, including workload and connector prerequisite checks. Exact command:
Official full solution validation: failed, exit code 1; 13 validators passed, 1 failed, 10 skipped. ARM-TTK reported 48 tests passed and 3 failed. Detection Schema and Non-ASCII .NET checks were skipped because .NET Core 3.1 was unavailable; the .NET KQL check reported no executed tests. Skips are not passes. Exact command:
pwsh /Users/oferinbar/Documents/Gits/Azure-Sentinel-autonamous-authoring/.script/local-validation/build-and-validate.ps1 \ -SolutionName CiscoASA \ -ContentRoot /Users/oferinbar/Documents/Gits/Azure-Sentinel-1 \ -SkipPackaging \ -VersionBump none \ -ValidationSkip "" \ -EvidenceDirectory .script/local-validation/Logs/cisco-provenance-validationGenerated-artifact checks passed: 3 installations, 3 registrations, and 3 stored installations have matching provenance; full registration dependencies match YAML. ZIP contents match the generated templates, and all detections remain disabled.
Whitespace check: passed. Exact command:
Checked that the validations are passing and have addressed any issues that are present: