Repository navigation
DO NOT MERGE draft PR - #1
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8553aac-d21b-4e0c-a24a-6dbb12de8a9e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
createUiDefinition.json,testParameters.json, andPackage/3.1.2.zipfor each solution, plus the corresponding solution-data selections, metadata, release notes, and approved source-content corrections.Reason for Change(s):
Discovery -> Conversion -> Validation -> Packaging -> Report: inventory the complete source-rule selection, perform deterministic conversion, resolve uncertain mappings through explicit source/query-hash-bound reviews, validate generated YAML and current offline evidence, package through the V3.1 route, and retain artifact hashes and an honest consolidated report.workflow-state.json. Package evidence must match current inputs; changed content requires an explicitly approved release action or a guarded same-version rebuild rather than silently reusing old package evidence. Review acceptance does not prove runtime correctness or alert parity.kind: NRT, but its generated XDR counterpart is scheduled atPT1H(hourly). Its inherited "NRT" display name does not make it an XDR NRT detection. The conversion warning records that source NRT timing is not preserved.Version Updated:
Testing Completed:
The recorded cross-checkout validation-only invocations are shown below with absolute checkout paths abbreviated as
$ToolkitRootand$ContentRoot. Evidence-directory arguments identify the original runs. No packaging or version bump was requested by these validation invocations.Checked that the validations are passing and have addressed any issues that are present:
TemplateTextinto expansion. The failure was reproduced without modifying the generated template or the validation implementation. The precise resolver branch/minimal upstream fixture remains unisolated; no layout workaround is claimed.0ec9a41a4503e970a0ec8efb0cd08415cc172175(module 0.27). Simply updating to a newer available upstream version was not a demonstrated remedy.