Await acks for write SDO, filter endpoint IDs#22
Open
solomondg wants to merge 1 commit into
Open
Conversation
solomondg
force-pushed
the
feature/await-sdo-acks
branch
from
2996d1f to
3c70a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ODrive sends a TxSdo in response to any RxSdo, writes included. setEndpoint() was firing the write and returning true unconditionally, with no confirmation it landed.
This makes setEndpoint() wait for that ACK. Mirrors getEndpoint(): it gains an optional timeout_ms = 10 param and returns true only when an acknowledgment arrives whose echoed Endpoint_ID matches the write (timeout_ms = 0 keeps the old behavior).
getEndpoint() now also discards any TxSdo that echoes a different endpoint than requested.