Repository navigation
Conversation
The cursor was drawn with a ONE/INVSRCALPHA blend function but without enabling blending. In an HDR pipeline libobs renders the source into a texture with blending disabled, so the transparent cursor pixels overwrote the frame and showed as a black square.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
enables blending before drawing the PipeWire cursor, the blend function was set but blending was never turned on.
Motivation and Context
the PipeWire source doesnt report a color space, so with Rec. 2100 libobs draws it into a texture with blending disabled (
obs-source.c), and the cursors transparent pixels overwrite the frame, the black square from the issue. in SDR that path isnt used so it worked. the existinggs_blend_state_push/poprestores the state afterwards.Fixes #13350
How Has This Been Tested?
built linux-pipewire, no HDR Wayland session to test it on.
Types of changes
Checklist: