Repository navigation
cogs.util.github: Show merged PRs for multi-commit pushes - #18
prgmitchell wants to merge 1 commit into
Conversation
8edcf0a to
305f573
Compare
|
I think at this point it makes more sense to just split I defer to you on whether you agree and wish to perform that refactor though @prgmitchell. If not, I am fine to merge this as-is. |
Show the matching merged PR for pushes containing multiple commits.
305f573 to
ed8028a
Compare
|
@Warchamp7 although I wanted to say just merge as-is, I agree splitting makes sense and know if it isn't done now it probably won't ever be. PR updated, let me know what you think. |
Warchamp7
left a comment
There was a problem hiding this comment.
Non blocking review testing. Ignore me.
| embed.timestamp = dateutil.parser.parse(pr['merged_at']) | ||
| embed.set_footer(text='Merged Pull Request') | ||
| embed.add_field(name='Branch', value=branch, inline=True) | ||
| return [(embed, head_hash)] |
There was a problem hiding this comment.
I'm not a fan of doing an early return here instead of filling out embed_commits but it's fine.
I'm also only submitting this review to test something so you can ignore it entirely.
Description
Show the matching merged PR for pushes containing multiple commits.
Motivation and Context
When multi-commit PRs get merged it makes more sense to see the PR itself rather than the just the last commit.
How Has This Been Tested?
It really hasn't, but seems good to me.
Types of changes
Checklist: