Skip to content

fetchers: Restrict requests - #211

Merged
RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:restrict-requests
Oct 20, 2026
Merged

RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:restrict-requests

Conversation

@RytoEX

@RytoEX RytoEX commented Oct 19, 2026

Copy link
Copy Markdown
Member

Description

fetchers: Add request timeouts

Prevent get requests from running forever by adding a naive timeout of 5 seconds.


fetchers: Disable redirects when fetching logs

Motivation and Context

Prevent get requests from running forever against unresponsive or extremely slow hosts.

Disable redirects to force URLs to be explicit.

How Has This Been Tested?

Tested a log URL analysis.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Prevent get requests from running forever by adding a naive timeout of 5
seconds.
@RytoEX
RytoEX requested review from notr1ch and prgmitchell October 19, 2026 17:59
Comment thread checks/utils/fetchers.py
@RytoEX
RytoEX force-pushed the restrict-requests branch from b054a32 to 6578396 Compare October 20, 2026 13:27
Additionally, remove the www. portion of the base URL if it exists to
avoid redirects even if they are valid.
@RytoEX
RytoEX force-pushed the restrict-requests branch from 6578396 to c19a38f Compare October 20, 2026 14:03
@RytoEX
RytoEX merged commit 51e495e into obsproject:master Oct 20, 2026
2 checks passed
@RytoEX
RytoEX deleted the restrict-requests branch October 20, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants