Skip to content

fetchers: Bound URL regex patterns - #209

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
RytoEX:fix-xss
Oct 19, 2026
Merged

RytoEX merged 1 commit into
obsproject:masterfrom
RytoEX:fix-xss

Conversation

@RytoEX

@RytoEX RytoEX commented Oct 16, 2026

Copy link
Copy Markdown
Member

Description

fetchers: Bound URL regex patterns

Make URL patterns match only within start of line and end of line boundaries.

Motivation and Context

This reduces the possibility of accepting malformed URLs and addresses a possible XSS issue.

How Has This Been Tested?

I tested log files from obsproject.com and cdn.discordapp.com successfully.

The URL formats for gist.github.com and hastebin have changed, so they could not be tested here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
RytoEX requested review from notr1ch and prgmitchell October 16, 2026 21:17
This reduces the possibility of accepting malformed URLs and addresses a
possible XSS issue.
@RytoEX
RytoEX merged commit 628ee5f into obsproject:master Oct 19, 2026
2 checks passed
@RytoEX
RytoEX deleted the fix-xss branch October 19, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants