Skip to content

Escape HTML from log file input in various places - #208

Merged
RytoEX merged 6 commits into
obsproject:masterfrom
RytoEX:fix-xss-02
Oct 19, 2026
Merged

RytoEX merged 6 commits into
obsproject:masterfrom
RytoEX:fix-xss-02

Conversation

@RytoEX

@RytoEX RytoEX commented Oct 16, 2026

Copy link
Copy Markdown
Member

Description

Escape possible HTML from log input in various places that display that input to the user.

Motivation and Context

Address possible XSS issues.

How Has This Been Tested?

Tested a couple of log files that previously worked to verify that they still worked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
RytoEX requested review from notr1ch and prgmitchell October 16, 2026 21:16
Comment thread checks/utils/fetchers.py
Comment thread checks/linux.py

@prgmitchell prgmitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest change fixes the wayland detection, tested with this log
https://obsproject.com/forum/attachments/obs-log-txt.80309/

@RytoEX
RytoEX merged commit eb05cf9 into obsproject:master Oct 19, 2026
2 checks passed
@RytoEX
RytoEX deleted the fix-xss-02 branch October 19, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants