Skip to content

Update plugin paths to new first-party paths #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RytoEX merged 2 commits into from
Sep 25, 2026
Merged

Update plugin paths to new first-party paths #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e0b1b3
extra/nsis: Updater installer script for new plugin paths
RytoEX Sep 25, 2026
72ca49b
prepare: Copy new path for first-party plugins
RytoEX Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions extra/nsis/mp-installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,10 @@ Function checkDLLs
OBSInstallerUtils::ResetInUseFileChecks
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\bin\64bit\avutil-57.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\bin\64bit\swscale-6.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\core\win-capture\data\graphics-hook32.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\core\win-capture\data\graphics-hook64.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\core\win-dshow\data\obs-virtualcam-module32.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\core\win-dshow\data\obs-virtualcam-module64.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\data\obs-plugins\win-capture\graphics-hook32.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\data\obs-plugins\win-capture\graphics-hook64.dll"
OBSInstallerUtils::AddInUseFileCheck "$INSTDIR\data\obs-plugins\win-dshow\obs-virtualcam-module32.dll"
Expand Down Expand Up @@ -250,16 +254,22 @@ Section "OBS Studio" SecCore
; Set Section Files and Shortcuts
SetOutPath "$INSTDIR"

; Copy data directory
File /r "${BUILDDIR}\data"

; Delete old Qt5 files
SetOutPath "$INSTDIR\bin"
Delete "$INSTDIR\bin\64bit\Qt5*.*"
; Copy bin\64bit
File /r "${BUILDDIR}\bin\64bit"
; Delete discontinued plugins
SetOutPath "$INSTDIR\obs-plugins"
Delete "$INSTDIR\obs-plugins\64bit\decklink-ouput*.*"
Delete "$INSTDIR\obs-plugins\64bit\win-decklink*.*"
Delete "$INSTDIR\obs-plugins\64bit\win-mf*.*"
File /r "${BUILDDIR}\obs-plugins\64bit"
; Copy new plugins
SetOutPath "$INSTDIR"
File /r "${BUILDDIR}\core"

; 64 bit Visual Studio 2022 runtime check
ClearErrors
Expand All @@ -279,23 +289,30 @@ Section "OBS Studio" SecCore

SetShellVarContext all

; Copy data directory
SetOutPath "$INSTDIR"
File /r "${BUILDDIR}\data"
; Kill browser plugin process in old paths
SetOutPath "$INSTDIR\obs-plugins"
OBSInstallerUtils::KillProcess "32bit\obs-browser-page.exe"
${if} ${RunningX64}
OBSInstallerUtils::KillProcess "64bit\obs-browser-page.exe"
${endif}
File /r "${BUILDDIR}\obs-plugins\64bit"
; Kill browser plugin process in new path
SetOutPath "$INSTDIR\core\obs-browser"
OBSInstallerUtils::KillProcess "obs-browser-page.exe"
; Copy new plugins
SetOutPath "$INSTDIR"
File /r "${BUILDDIR}\core"
SetOutPath "$INSTDIR\bin\64bit"

# ----------------------------
# Copy game capture files to ProgramData
SetOutPath "$APPDATA\obs-studio-hook"
File "${BUILDDIR}\data\obs-plugins\win-capture\graphics-hook32.dll"
File "${BUILDDIR}\data\obs-plugins\win-capture\graphics-hook64.dll"
File "${BUILDDIR}\data\obs-plugins\win-capture\obs-vulkan32.json"
File "${BUILDDIR}\data\obs-plugins\win-capture\obs-vulkan64.json"
File "${BUILDDIR}\core\win-capture\data\graphics-hook32.dll"
File "${BUILDDIR}\core\win-capture\data\graphics-hook64.dll"
File "${BUILDDIR}\core\win-capture\data\obs-vulkan32.json"
File "${BUILDDIR}\core\win-capture\data\obs-vulkan64.json"
OBSInstallerUtils::AddAllApplicationPackages "$APPDATA\obs-studio-hook"

WriteUninstaller "$INSTDIR\uninstall.exe"
Expand Down Expand Up @@ -343,9 +360,9 @@ Section -FinishSection
# ---------------------------------------
# Register virtual camera dlls

Exec '"$SYSDIR\regsvr32.exe" /s "$INSTDIR\data\obs-plugins\win-dshow\obs-virtualcam-module32.dll"'
Exec '"$SYSDIR\regsvr32.exe" /s "$INSTDIR\core\win-dshow\data\obs-virtualcam-module32.dll"'
${if} ${RunningX64}
Exec '"$SYSDIR\regsvr32.exe" /s "$INSTDIR\data\obs-plugins\win-dshow\obs-virtualcam-module64.dll"'
Exec '"$SYSDIR\regsvr32.exe" /s "$INSTDIR\core\win-dshow\data\obs-virtualcam-module64.dll"'
${endif}

# ---------------------------------------
Expand Down Expand Up @@ -397,12 +414,18 @@ Section "un.${APPNAME} App Files" UninstallSection1
SetShellVarContext current
ClearErrors

; Unregister virtual camera dlls
; Unregister old virtual camera dlls
Exec '"$SYSDIR\regsvr32.exe" /u /s "$INSTDIR\data\obs-plugins\win-dshow\obs-virtualcam-module32.dll"'
${if} ${RunningX64}
Exec '"$SYSDIR\regsvr32.exe" /u /s "$INSTDIR\data\obs-plugins\win-dshow\obs-virtualcam-module64.dll"'
${endif}

; Unregister virtual camera dlls
Exec '"$SYSDIR\regsvr32.exe" /u /s "$INSTDIR\core\win-dshow\data\obs-virtualcam-module32.dll"'
${if} ${RunningX64}
Exec '"$SYSDIR\regsvr32.exe" /u /s "$INSTDIR\core\win-dshow\data\obs-virtualcam-module64.dll"'
${endif}

; Remove from registry...
DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"
DeleteRegKey HKLM "SOFTWARE\${APPNAME}"
Expand All @@ -423,6 +446,7 @@ Section "un.${APPNAME} App Files" UninstallSection1

; Clean up OBS Studio
RMDir /r "$INSTDIR\bin"
RMDir /r "$INSTDIR\core"
RMDir /r "$INSTDIR\data"
RMDir /r "$INSTDIR\obs-plugins"
RMDir "$INSTDIR"
Expand Down
1 change: 1 addition & 0 deletions src/steps/prepare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ fn copy_files(

// ToDo figure out if this should be configurable
if !relative_path.starts_with("bin")
&& !relative_path.starts_with("core")
&& !relative_path.starts_with("data")
&& !relative_path.starts_with("obs-plugins")
{
Expand Down
Loading