Skip to content

transforms should respect *z* series specified as {value: z} #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

transforms should respect *z* series specified as {value: z} #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ export function maybeTuple(x, y) {
export function maybeZ({z, fill, stroke} = {}) {
if (z === undefined) [z] = maybeColorChannel(fill);
if (z === undefined) [z] = maybeColorChannel(stroke);
if (isOptions(z)) z = z.value;
Copy link
Copy Markdown
Contributor Author

@Fil Fil Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: other properties on the options z could be:

  • scale — which scale to use
  • label — a label for axes/legends
  • hint — internal hints (e.g., {length: true} for stack)
  • filter — a filter function for the channel
  • optional — whether the channel can be null

none of these matter to determine how to group series.

return z;
}

Expand Down
70 changes: 70 additions & 0 deletions test/output/zValueSelect.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
84 changes: 84 additions & 0 deletions test/output/zValueStack.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading