Conversation
Fil
self-requested a review
July 13, 2026 18:16
Fil
reviewed
Jul 14, 2026
Fil
reviewed
Jul 14, 2026
mbostock
reviewed
Jul 14, 2026
mbostock
reviewed
Jul 14, 2026
mbostock
reviewed
Jul 14, 2026
| return (await response.json().then(revive)) as QueryResult<T>; | ||
| } | ||
| async cachePath(strings: readonly string[], ...params: QueryParam[]): Promise<string> { | ||
| return `.observable/cache/${await nameHash(this.name)}-${await hash(strings, ...params)}.json`; |
Member
There was a problem hiding this comment.
Suggested change
| return `.observable/cache/${await nameHash(this.name)}-${await hash(strings, ...params)}.json`; | |
| return `.observable/cache/${await nameHash(this.name)}-${await hash(strings, ...params)}.arrow`; |
Contributor
There was a problem hiding this comment.
btw should we Promise.all these two awaits?
mbostock
reviewed
Jul 14, 2026
mbostock
marked this pull request as ready for review
August 13, 2026 11:58
mbostock
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/observable/issue/DEV-1662/sql-fragments
To do
!assertions