Repository navigation
Conversation
Warn on stderr for changed pnpm/yarn/bun/shrinkwrap lockfiles (matched by basename) and exit 1 under --fail-on-downgrade, since they can't be verified. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oalders
marked this pull request as ready for review
October 8, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Changes
bin/diff-lockfiles.js: changed files whose basename ispnpm-lock.yaml,yarn.lock,bun.lock,bun.lockb, ornpm-shrinkwrap.json(any directory) are reported on stderr asUnsupported lockfile changed, not diffed: <path>.--fail-on-downgrade, any such change exits1, taking precedence over2.0), and stdout is identical either way.git diff --name-onlynow uses-z(NUL-delimited). Without it, git C-quotes non-ASCII paths (e.g."caf\303\251/yarn.lock"), so both the new check and the existingpackage-lock.jsonfilter silently missed them (fail-open).README.mdandCLAUDE.mddocument the new exit-code behaviour.Testing
1, identical stdout with and without the flag).bin/diff-lockfiles.jsand pass with the fix.npm test: 37/37 pass.npm run lint: clean.Declined findings
/package-lock\.json$/: pre-existing; commit 84d480e chose "ends with" on purpose.--no-renames, case-insensitive or glob matching, addingdeno.lock: no real producer of those cases; the list matches the issue scope.1in the--helptext: the README exit-code table documents it, and reviewers disagreed with each other on this.CLAUDE.mdrewording (re-splitting the exit-code clause, dropping the-znote): already addressed in round 1; the-znote guards against removing it.ubuntu-latest.🤖 Generated with Claude Code · Opus 5.5