docs(governance): fix workflow catalog, Actions allow-list, and locked-count drift#44
Draft
bryanfawcett wants to merge 2 commits into
Draft
docs(governance): fix workflow catalog, Actions allow-list, and locked-count drift#44bryanfawcett wants to merge 2 commits into
bryanfawcett wants to merge 2 commits into
Conversation
README's reusable-workflow table was missing three shipped workflows (reusable-ci-typescript-lib.yml, reusable-ci-terraform.yml, reusable-ci-docker.yml). ORG_SETTINGS.md's Actions allow-list was missing hashicorp/setup-terraform and terraform-linters/setup-tflint, both used by reusable-ci-terraform.yml -- under the "Allow select actions" policy this repo declares, those actions would be blocked. Also corrected the ruleset audit notes, which described 2-approver / 1-approver review counts that don't match the 0-approver pre-scale posture actually encoded in the ruleset JSON and the branch-protection table earlier in the same document. Signed-off-by: Bryan Fawcett <bryan@nyuchi.com> Signed-off-by: Claude <noreply@anthropic.com>
… template NA-03 v1.6 removed "7 Nyuchi Enterprise products" from the locked-counts list -- the product line is explicitly uncapped and grows over time. The PR template's NA-03 merge-blocker checklist still listed it, which would prompt contributors to enforce a cap the governance document no longer recognizes. Signed-off-by: Bryan Fawcett <bryan@nyuchi.com> Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine maintenance audit of the org-governing
.githubrepo. The repo is already heavily maintained (SHA-pinned actions, SLSA provenance, quarterly settings audit, etc.), so rather than re-deriving already-current dependency pins, this PR fixes three concrete cases of documentation/config drifting out of sync with the actual state of the repo:.github/workflows/:reusable-ci-typescript-lib.yml,reusable-ci-terraform.yml, andreusable-ci-docker.yml. Added rows describing each, matching the style of existing entries.Settings → Actions → General → Allow specified actions) was missinghashicorp/setup-terraform@*andterraform-linters/setup-tflint@*, both of whichreusable-ci-terraform.ymlactually uses. Under the "allow select actions only" policy this document declares, those two actions would be blocked from running. Added them to the allow-list, consistent with the existing entries for the OpenTofu/Docker equivalents.main-branch-protection.jsonas "2-approver" andorg-wide-main-protection.jsonas "1-approver." Both ruleset JSON files actually setrequired_approving_review_count: 0(the documented pre-scale posture from the branch-protection table earlier in the same file). Corrected the prose to match the JSON..github/PULL_REQUEST_TEMPLATE.md: the NA-03 merge-blocker checklist still listed "7 Enterprise products" as a locked count. NA-03 v1.6 explicitly removed that line — the Enterprise product line is uncapped and grows over time (also called out in this repo'sCLAUDE.md). Updated the checklist to match NA-03 §3.3 and added a note so contributors don't re-add the cap.No workflow logic, action pins, or governance substance changed — only documentation/config brought back in sync with what's already true.
Linked issue(s)
N/A — found via a full-repo maintenance audit, not tracked by an existing issue.
Type of change
docs— documentation onlyBreaking change?
How has this been tested?
on: workflow_callinputs to write accurate one-line descriptions.grep -rhoE 'uses: [^@[:space:]]+' .github/workflows/ | sort -u(the exact audit command this repo's ownORG_SETTINGS.mddocuments) and diffing against the allow-list.github-rulesets/main-branch-protection.jsonandgithub-rulesets/org-wide-main-protection.jsondirectly.prettier --check(v3.9.4, matchingreusable-lint.yml's pin) andmarkdownlint-cli2(v0.18.1) against every changed file — both pass with zero findings.Checklist
Process
git commit -s, using the human operator's identity).claude/<topic>-<suffix>reserved prefix.NA-03 merge blockers
Additional notes
Opened as a draft per this repo's
CLAUDE.mddefault for human-initiated review. Happy to fold in any further drift the maintainer wants addressed in the same PR.Generated by Claude Code