Skip to content

Map engine Configuration errors to 400 (detect-but-never-redact) #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martsokha merged 1 commit into from
Aug 29, 2026
Merged

Map engine Configuration errors to 400 (detect-but-never-redact) #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 10 additions & 5 deletions crates/nvisy-server/src/handler/error/engine_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
//! Redaction-engine error to HTTP error conversion.
//!
//! Maps `elide_pipeline::Error` onto an HTTP error by its kind: a
//! `MalformedInput` is a bad document the caller supplied (a client error),
//! while every other kind — including `CapabilityUnavailable` (a codec/renderer
//! the build does not ship) — is a server-side processing fault. The engine's
//! own message travels along as context.
//! Maps `elide_pipeline::Error` onto an HTTP error by its kind. Two kinds are
//! caller errors: `MalformedInput` is a bad document the caller supplied, and
//! `Configuration` is an incoherent request or policy set (e.g. policies that can
//! detect but never redact, or a reviewer override naming an off-pipeline
//! policy). Every other kind — including `CapabilityUnavailable` (a codec or
//! renderer the build does not ship) — is a server-side processing fault. The
//! engine's own message travels along as context.

use elide_pipeline::ErrorKind as EngineErrorKind;
use elide_pipeline::entity::EditError;
Expand All @@ -17,6 +19,9 @@ impl<'a> From<elide_pipeline::Error> for HttpError<'a> {
EngineErrorKind::MalformedInput => ErrorKind::BadRequest
.with_message("Document could not be processed")
.with_context(error.to_string()),
EngineErrorKind::Configuration => ErrorKind::BadRequest
.with_message("The pipeline's policies cannot process this request")
.with_context(error.to_string()),
_ => ErrorKind::InternalServerError
.with_message("Redaction engine failed")
.with_context(error.to_string()),
Expand Down