feat: [GH-159] Add Elgato Master Mix Control - #160
Closed
beanbeanjuice wants to merge 2 commits into
Closed
beanbeanjuice wants to merge 2 commits into
beanbeanjuice wants to merge 2 commits into
Conversation
nvdweem
pushed a commit
that referenced
this pull request
Sep 14, 2026
…olver test Follow-up to #160: expose the mix image on WaveLinkMixDto so a Master Mix command shows its Elgato icon on the device preview like channels do, add the release-notes bullet for #159, cover the MixMaster mute resolution, and drop the inline narration comments. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Owner
|
The commits were cherry picked instead of having the pull-request accepted, so they are now in the latest snapshot. If you have set auto updates to snapshots enabled, it should update automatically on the next startup. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an example of how GH-159 may be done. This was hastily done using
CTRL+Fin IntelliJ and just modifying code where "Mix" was present and adding a "MixMaster" option. I highly recommend testing this properly or even scrapping it entirely and simply just using it as a basis for how to implement GH-159.I don't know if I'm missing anything, and I haven't added any unit tests.
Testing
I tested it myself by running
mvn quarkus:dev, but I didn't try to compile it into an executable or anything like that. The implementation does work in changing the master control volume, but I didn't check too hard to see if there were any bad side-effects.AI Disclaimer
Most added code was written myself. Adding it was pretty much self-explanatory since you already had the other stuff for the normal mix/channels, but I did have claude help with the following:
src/main/webui/src/app/features/commands/command-fields.component.ts.src/main/java/dev/niels/wavelink/IWaveLinkClient.java. It was originally much more convoluted.