Repository navigation
fix(deps): declare h3 as a runtime dependency - #654
Open
mayuriphad wants to merge 1 commit into
Open
mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
The server runtime imports from h3 without declaring it, so under pnpm it resolves to whatever h3 the app hoists. With h3 v2 hoisted, getRequestHeader fails with "event.req.headers.get is not a function". Resolves nuxt-modules#651 Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
|
@mayuriphad is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Resolves #651
The server runtime (
serverSupabaseClient,serverSupabaseUser,serverSupabaseSession,serverSupabaseServiceRole,utils/cookies,plugins/supabase.server) imports fromh3, buth3is not a dependency of the module. Under pnpm's strict layout, the import resolves to whicheverh3gets hoisted in the app. When another package pulls in h3 v2, the module'sgetRequestHeader/cookie helpers run against the v2 API with a v1 event, which fails withevent.req.headers.get is not a function.This declares
h3as a runtime dependency with the same^1.15.11range the workspace already pins inpnpm-workspace.yamloverrides, so the module always resolves the h3 v1 it is written for. The lockfile entry reuses theh3@1.15.11package already in the lockfile.I hand-edited the root importer in
pnpm-lock.yamland did not runpnpm installlocally; CI's frozen-lockfile install will confirm it.Checklist: