Skip to content

fix(mesh): raise the check-in period to 5m on large clusters #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IvanHunters wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mesh): raise the check-in period to 5m on large clusters #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/mesh/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,17 @@ import (
)

const (
// checkInPeriod is how often nodes should check-in.
checkInPeriod = 30 * time.Second
// checkInPeriod is how often nodes should check in. It is deliberately
// raised above the upstream default of 30s. A node's WireGuard IP is
// assigned by its rank in the currently Ready set, and a node is Ready
// only while its last-seen is within twice this value. On large clusters
// the per-node last-seen writes create enough watch churn that liveness
// cannot propagate within a 60s window, collapsing every agent's Ready set
// and colliding most nodes on the first address of the subnet. A longer
// period widens the freshness window so the Ready set stays close to the
// full node set. This is a mitigation, not a root-cause fix; see
// https://github.com/squat/kilo/issues/549.
checkInPeriod = 5 * time.Minute
// DefaultKiloInterface is the default interface created and used by Kilo.
DefaultKiloInterface = "kilo0"
// DefaultKiloPort is the default UDP port Kilo uses.
Expand Down